Skip to content

Fix test framework's groupby expression support#5419

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
Willendless:fix-issue-5418
Jul 21, 2022
Merged

Fix test framework's groupby expression support#5419
ti-chi-bot merged 7 commits intopingcap:masterfrom
Willendless:fix-issue-5418

Conversation

@Willendless
Copy link
Contributor

@Willendless Willendless commented Jul 19, 2022

What problem does this PR solve?

Issue Number: close #5418

Problem Summary:

What is changed and how it works?

  • check whether agg/groupby ASTPtr is null before pushing them into expression list

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2022
@Willendless
Copy link
Contributor Author

Willendless commented Jul 19, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                           Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp         119                50    57.98%           3                 0   100.00%          52                 0   100.00%          32                18    43.75%
TestUtils/mockExecutor.cpp              76                 4    94.74%          43                 2    95.35%         280                27    90.36%          38                 2    94.74%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  195                54    72.31%          46                 2    95.65%         332                27    91.87%          70                20    71.43%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18626      9373             49.68%    212372  94729        55.39%

full coverage report (for internal network access only)

@Willendless
Copy link
Contributor Author

Willendless commented Jul 19, 2022

/run-integration-test

SeaRise
SeaRise approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dbms/src/Flash/tests/gtest_executor.cpp Outdated
}
CATCH

// todo: move this test to gtest_aggregation_executor.cpp
Copy link
Contributor

@SeaRise SeaRise Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can do now?

Copy link
Contributor Author

@Willendless Willendless Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
ywqzzy
ywqzzy approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@Willendless Willendless changed the title Fix test framework's groupby expression support [WIP] Fix test framework's groupby expression support Jul 20, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@Willendless Willendless changed the title [WIP] Fix test framework's groupby expression support Fix test framework's groupby expression support Jul 20, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@Willendless
Copy link
Contributor Author

Willendless commented Jul 20, 2022

/run-all-tests

@Willendless
Copy link
Contributor Author

Willendless commented Jul 20, 2022

/cc @xzhangxian1008

feel free to modify my test case when you support more aggregation expressions and add corresponding tests

:)

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 20, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_aggregation_executor.cpp         289                97    66.44%           7                 0   100.00%         179                 1    99.44%          70                35    50.00%
TestUtils/mockExecutor.cpp                          76                 4    94.74%          43                 2    95.35%         280                27    90.36%          38                 2    94.74%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              365               101    72.33%          50                 2    96.00%         459                28    93.90%         108                37    65.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18626      9374             49.67%    212376  94710        55.40%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor

SeaRise commented Jul 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: c20e757

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_aggregation_executor.cpp         289                97    66.44%           7                 0   100.00%         179                 1    99.44%          70                35    50.00%
TestUtils/mockExecutor.cpp                          76                 4    94.74%          43                 2    95.35%         280                27    90.36%          38                 2    94.74%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              365               101    72.33%          50                 2    96.00%         459                28    93.90%         108                37    65.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18632      9372             49.70%    212524  94696        55.44%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_aggregation_executor.cpp         289                97    66.44%           7                 0   100.00%         179                 1    99.44%          70                35    50.00%
TestUtils/mockExecutor.cpp                          76                 4    94.74%          43                 2    95.35%         280                27    90.36%          38                 2    94.74%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              365               101    72.33%          50                 2    96.00%         459                28    93.90%         108                37    65.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18632      9374             49.69%    212524  94731        55.43%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022

@Willendless: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

Filename                                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_aggregation_executor.cpp         289                97    66.44%           7                 0   100.00%         179                 1    99.44%          70                35    50.00%
TestUtils/mockExecutor.cpp                          76                 4    94.74%          43                 2    95.35%         280                27    90.36%          38                 2    94.74%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              365               101    72.33%          50                 2    96.00%         459                28    93.90%         108                37    65.74%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18632      9373             49.69%    212519  94684        55.45%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 15478d7 into pingcap:master Jul 21, 2022
@Willendless Willendless deleted the fix-issue-5418 branch July 21, 2022 20:31
@ywqzzy ywqzzy mentioned this pull request Aug 25, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xzhangxian1008 xzhangxian1008 Awaiting requested review from xzhangxian1008

2 more reviewers

@SeaRise SeaRise SeaRise approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Executor test framework failed to support aggregation without groupby expr

5 participants

@Willendless @ti-chi-bot @sre-bot @SeaRise @ywqzzy