Skip to content

DAGContext: remove useless explicitly call to tunnel_set's default ctor#5417

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
fuzhe1989:fuzhe/remove_mpp_tunnelset_ctor
Jul 19, 2022
Merged

DAGContext: remove useless explicitly call to tunnel_set's default ctor#5417
ti-chi-bot merged 2 commits intopingcap:masterfrom
fuzhe1989:fuzhe/remove_mpp_tunnelset_ctor

Conversation

@fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Jul 19, 2022

Signed-off-by: fuzhe1989 fuzhe1989@gmail.com

What problem does this PR solve?

Issue Number: ref #5416

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@fuzhe1989
DAGContext: remove useless explicitly call to 's default ctor
e540504 
Signed-off-by: fuzhe1989 <fuzhe1989@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • gengliqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 19, 2022
@fuzhe1989 fuzhe1989 changed the title DAGContext: remove useless explicitly call to 's default ctor DAGContext: remove useless explicitly call to tunnel_set's default ctor Jul 19, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Jul 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e540504

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

@fuzhe1989: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                                                                                               Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/Coprocessor/DAGContext.h          41                14    65.85%          32                12    62.50%          91                34    62.64%          12                 6    50.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                       41                14    65.85%          32                12    62.50%          91                34    62.64%          12                 6    50.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18625      9392             49.57%    212350  94883        55.32%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 079d3c9 into pingcap:master Jul 19, 2022
@fuzhe1989 fuzhe1989 deleted the fuzhe/remove_mpp_tunnelset_ctor branch July 20, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengliqi gengliqi gengliqi approved these changes

+1 more reviewer

@LittleFall LittleFall LittleFall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fuzhe1989 @ti-chi-bot @sre-bot @gengliqi @LittleFall