Skip to content

refine log in creating set for join build#5404

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
windtalker:join_log
Jul 19, 2022
Merged

refine log in creating set for join build#5404
ti-chi-bot merged 3 commits intopingcap:masterfrom
windtalker:join_log

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Jul 19, 2022

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: close #5403

Problem Summary:

What is changed and how it works?

  1. Join will save the total build input rows
  2. For join, CreatingSetsBlockInputStream get the head_rows from subquery.join directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
refine log in creating set for join build
4edeff3 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2022
@SeaRise SeaRise self-requested a review July 19, 2022 05:10
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 19, 2022
yibin87
yibin87 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@yibin87
Copy link
Contributor

yibin87 commented Jul 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

@yibin87: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4edeff3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/CreatingSetsBlockInputStream.cpp         190                75    60.53%          11                 2    81.82%         215                65    69.77%         120                59    50.83%
Interpreters/Join.cpp                               1298               652    49.77%          82                37    54.88%        1429               682    52.27%         868               462    46.77%
Interpreters/Join.h                                   20                 1    95.00%          17                 0   100.00%          29                 1    96.55%           2                 1    50.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               1508               728    51.72%         110                39    64.55%        1673               748    55.29%         990               522    47.27%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18619      9408             49.47%    212190  94996        55.23%

full coverage report (for internal network access only)

@windtalker
Copy link
Contributor Author

windtalker commented Jul 19, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 5792db6 into pingcap:master Jul 19, 2022
@windtalker windtalker deleted the join_log branch May 6, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Log in CreatingSetsBlockInputStream always shows join build has empty result

5 participants

@windtalker @ti-chi-bot @yibin87 @sre-bot @SeaRise