Skip to content

change some default config of ps v3#5398

Merged
ti-chi-bot merged 2 commits intopingcap:masterfrom
lidezhu:change-ps-v3-config
Jul 19, 2022
Merged

change some default config of ps v3#5398
ti-chi-bot merged 2 commits intopingcap:masterfrom
lidezhu:change-ps-v3-config

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Jul 18, 2022 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary: Change some default config to decrease the possible space amplification.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 18, 2022
JaySon-Huang
JaySon-Huang approved these changes Jul 18, 2022
View reviewed changes
dbms/src/Storages/Page/PageDefines.h

// PageStorage V3 define
static constexpr UInt64 BLOBFILE_LIMIT_SIZE = 512 * MB;
static constexpr UInt64 BLOBFILE_LIMIT_SIZE = 256 * MB;
Copy link
Contributor

@JaySon-Huang JaySon-Huang Jul 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: turning it into a smaller value may make some issue for the developers testing on the master branch

Copy link
Contributor Author

@lidezhu lidezhu Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 19, 2022
@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 19, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

@flowbehappy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2f47386

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 19, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 19, 2022

@lidezhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 19, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PageDefines.h                       8                 2    75.00%           8                 2    75.00%          14                 4    71.43%           0                 0         -
PageStorage.h                      21                 4    80.95%          21                 4    80.95%          93                12    87.10%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              29                 6    79.31%          29                 6    79.31%         107                16    85.05%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18617      9408             49.47%    212150  95026        55.21%

full coverage report (for internal network access only)

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 19, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Jul 19, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 75dbc1c into pingcap:master Jul 19, 2022
@lidezhu lidezhu deleted the change-ps-v3-config branch July 19, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lidezhu @ti-chi-bot @flowbehappy @sre-bot @JaySon-Huang