Skip to content

Read ThreadPool and Data Sharing of DeltaTree#5377

Merged
ti-chi-bot merged 34 commits intopingcap:masterfrom
JinheLin:read-thread-and-data-sharing
Jul 21, 2022
Merged

Read ThreadPool and Data Sharing of DeltaTree#5377
ti-chi-bot merged 34 commits intopingcap:masterfrom
JinheLin:read-thread-and-data-sharing

Conversation

@JinheLin
Copy link
Contributor

@JinheLin JinheLin commented Jul 15, 2022

What problem does this PR solve?

Issue Number: close #5376

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 15, 2022
@JinheLin JinheLin force-pushed the read-thread-and-data-sharing branch from 9c1c29c to da878a6 Compare July 16, 2022 06:50
JaySon-Huang
JaySon-Huang reviewed Jul 19, 2022
View reviewed changes
flowbehappy
flowbehappy reviewed Jul 19, 2022
View reviewed changes
@JinheLin JinheLin force-pushed the read-thread-and-data-sharing branch from 6e5d33e to 8704f06 Compare July 19, 2022 06:49
@JinheLin JinheLin changed the title [DNM]Read Thread and Data Sharing Read Thread and Data Sharing Jul 19, 2022
JaySon-Huang
JaySon-Huang reviewed Jul 19, 2022
View reviewed changes
flowbehappy
flowbehappy reviewed Jul 19, 2022
View reviewed changes
@JinheLin JinheLin force-pushed the read-thread-and-data-sharing branch from e963866 to 068a7ad Compare July 19, 2022 08:09
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2022
@flowbehappy flowbehappy changed the title Read Thread and Data Sharing Read ThreadPool and Data Sharing of DeltaTree Jul 19, 2022
flowbehappy
flowbehappy reviewed Jul 19, 2022
View reviewed changes
dbms/src/Storages/DeltaMerge/ReadThread/ColumnSharingCache.h
}
else if (target->second.pack_count < pack_count)
{
status = ColumnCacheStatus::GET_PART;
Copy link
Contributor

@flowbehappy flowbehappy Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is space to optimize this part further, i.e. even if part of the cache that exists can still be helpful.
But we can do it later.

Copy link
Contributor

@flowbehappy flowbehappy Jul 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And to reduce the chance of step mismatch of the split of packs, we can try to align the split point. For example, we always read packs by pack_id % 4 == 0.

Thread 1:       2, 3 | 4, 5, 6, 7 | 8, 9
Thread 2: 0, 1, 2, 3 | 4, 5, 6, 7 | 8

Copy link
Contributor Author

@JinheLin JinheLin Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree.

flowbehappy
flowbehappy reviewed Jul 19, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Jul 20, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@flowbehappy
Copy link
Contributor

flowbehappy commented Jul 20, 2022

LGTM

@flowbehappy flowbehappy self-requested a review July 20, 2022 11:12
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@JinheLin
Copy link
Contributor Author

JinheLin commented Jul 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f1e7e7e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18771      9462             49.59%    213938  95661        55.29%

full coverage report (for internal network access only)

@JinheLin
Copy link
Contributor Author

JinheLin commented Jul 21, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 21, 2022

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18771      9463             49.59%    213933  95660        55.29%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18772      9443             49.70%    213959  95443        55.39%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 71a298a into pingcap:master Jul 21, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18771      9458             49.61%    213938  95593        55.32%

full coverage report (for internal network access only)

@JinheLin JinheLin deleted the read-thread-and-data-sharing branch August 4, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker left review comments

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Read Thread Pool and DataSharing

6 participants

@JinheLin @ti-chi-bot @flowbehappy @sre-bot @windtalker @JaySon-Huang