*: Test DagRequest to MPPTasks by ywqzzy · Pull Request #5369 · pingcap/tiflash

ywqzzy · 2022-07-14T08:25:01Z

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-07-14T08:25:03Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Lloyd-Pottiger
SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

dbms/src/TestUtils/mockExecutor.cpp

dbms/src/Debug/dbgFuncCoprocessor.h

dbms/src/Flash/tests/gtest_split_tasks.cpp

guo-shaoge · 2022-07-14T11:58:21Z

dbms/src/Flash/tests/gtest_split_tasks.cpp

+                     .buildMPPTasks(context);
+
+    size_t task_size = tasks.size();
+    std::vector<String> executors = {


Looks cool. But what if swap executors[0] and executors[1] , it looks more comfortable. Because it's just like the output of explain!

Optional, not required.

SeaRise

LGTM

Lloyd-Pottiger

the rest LGTM

Lloyd-Pottiger · 2022-07-15T02:56:20Z

dbms/src/Flash/tests/gtest_split_tasks.cpp

+        context.addMockTable({"test_db", "test_table_1"}, {{"s1", TiDB::TP::TypeString}, {"s2", TiDB::TP::TypeString}, {"s3", TiDB::TP::TypeString}});
+        context.addMockTable({"test_db", "l_table"},
+                             {{"s", TiDB::TP::TypeString}, {"join_c", TiDB::TP::TypeString}});
+        context.addMockTable({"test_db", "r_table"},
+                             {{"s", TiDB::TP::TypeString}, {"join_c", TiDB::TP::TypeString}});


maybe unify the style?

ywqzzy · 2022-07-15T03:01:27Z

/merge

ti-chi-bot · 2022-07-15T03:01:28Z

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-15T03:01:29Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: a048ce6

sre-bot · 2022-07-15T03:19:16Z

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/dbgFuncCoprocessor.h                  1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/tests/gtest_split_tasks.cpp          67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                 72                 8    88.89%          43                 5    88.37%         278                38    86.33%          34                 3    91.18%
TestUtils/mockExecutor.h                    6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     146                47    67.81%          53                 6    88.68%         394                41    89.59%          50                11    78.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18578      9570             48.49%    210740  96355        54.28%

full coverage report (for internal network access only)

ywqzzy · 2022-07-15T05:08:14Z

/run-all-tests

sre-bot · 2022-07-15T05:28:43Z

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/dbgFuncCoprocessor.h                  1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/tests/gtest_split_tasks.cpp          67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                 72                 8    88.89%          43                 5    88.37%         278                38    86.33%          34                 3    91.18%
TestUtils/mockExecutor.h                    6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     146                47    67.81%          53                 6    88.68%         394                41    89.59%          50                11    78.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18578      9570             48.49%    210740  96374        54.27%

full coverage report (for internal network access only)

ywqzzy · 2022-07-15T05:55:16Z

/run-all-tests

ywqzzy · 2022-07-15T08:40:12Z

/run-unit-tests

sre-bot · 2022-07-15T08:52:30Z

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/dbgFuncCoprocessor.h                  1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/tests/gtest_split_tasks.cpp          67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                 72                 8    88.89%          43                 5    88.37%         278                38    86.33%          34                 3    91.18%
TestUtils/mockExecutor.h                    6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     146                47    67.81%          53                 6    88.68%         394                41    89.59%          50                11    78.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18580      9567             48.51%    210772  96352        54.29%

full coverage report (for internal network access only)

sre-bot · 2022-07-15T15:58:21Z

Coverage for changed files

Filename                              Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/dbgFuncCoprocessor.h                  1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/tests/gtest_split_tasks.cpp          67                38    43.28%           3                 0   100.00%         100                 0   100.00%          16                 8    50.00%
TestUtils/mockExecutor.cpp                 72                 8    88.89%          43                 5    88.37%         278                38    86.33%          34                 3    91.18%
TestUtils/mockExecutor.h                    6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                     146                47    67.81%          53                 6    88.68%         394                41    89.59%          50                11    78.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18580      9565             48.52%    210772  96304        54.31%

full coverage report (for internal network access only)

ywqzzy added 2 commits July 14, 2022 11:37

test join and agg

634884c

update.

63a5eb9

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2022

Merge branch 'master' into dag_request_to_tasks

aab3b3e

ywqzzy changed the title *: Test Dag request to tasks *: Test DagRequest to tasks Jul 14, 2022

refine.

e74b08f

SeaRise self-requested a review July 14, 2022 09:30

SeaRise reviewed Jul 14, 2022

View reviewed changes

dbms/src/TestUtils/mockExecutor.cpp Outdated Show resolved Hide resolved

dbms/src/TestUtils/mockExecutor.cpp Show resolved Hide resolved

dbms/src/Debug/dbgFuncCoprocessor.h Show resolved Hide resolved

dbms/src/Flash/tests/gtest_split_tasks.cpp Show resolved Hide resolved

address comments.

b375dff

ywqzzy changed the title *: Test DagRequest to tasks *: Test DagRequest to MPPTasks Jul 14, 2022

ywqzzy requested a review from guo-shaoge July 14, 2022 10:12

guo-shaoge reviewed Jul 14, 2022

View reviewed changes

SeaRise approved these changes Jul 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2022

Lloyd-Pottiger approved these changes Jul 15, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2022

ywqzzy added 2 commits July 15, 2022 11:00

update

b5f9c20

Merge branch 'master' into dag_request_to_tasks

a048ce6

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2022

Merge branch 'master' into dag_request_to_tasks

d4bab32

Merge branch 'master' into dag_request_to_tasks

a5e9804

ti-chi-bot merged commit 537e88a into pingcap:master Jul 15, 2022

ywqzzy mentioned this pull request Jul 27, 2022

Interpreter & Executor & MPP unit test framework #4609

Closed

54 tasks

Conversation

ywqzzy commented Jul 14, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jul 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

guo-shaoge Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

guo-shaoge Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

guo-shaoge Jul 14, 2022

Choose a reason for hiding this comment

Uh oh!

SeaRise left a comment

Choose a reason for hiding this comment

Uh oh!

Lloyd-Pottiger left a comment

Choose a reason for hiding this comment

Uh oh!

Lloyd-Pottiger Jul 15, 2022

Choose a reason for hiding this comment

Uh oh!

ywqzzy commented Jul 15, 2022

Uh oh!

ti-chi-bot commented Jul 15, 2022

Uh oh!

ti-chi-bot commented Jul 15, 2022

Uh oh!

sre-bot commented Jul 15, 2022

Coverage for changed files

Coverage summary

Uh oh!

ywqzzy commented Jul 15, 2022

Uh oh!

sre-bot commented Jul 15, 2022

Coverage for changed files

Coverage summary

Uh oh!

ywqzzy commented Jul 15, 2022

Uh oh!

ywqzzy commented Jul 15, 2022

Uh oh!

sre-bot commented Jul 15, 2022

Coverage for changed files

Coverage summary

Uh oh!

sre-bot commented Jul 15, 2022

Coverage for changed files

Coverage summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ti-chi-bot commented Jul 14, 2022 •

edited

Loading