Skip to content

fix: incorrect uptime in grafana panel#5358

Merged
ti-chi-bot merged 14 commits intopingcap:masterfrom
Lloyd-Pottiger:fix/incorrect-uptime
Jul 25, 2022
Merged

fix: incorrect uptime in grafana panel#5358
ti-chi-bot merged 14 commits intopingcap:masterfrom
Lloyd-Pottiger:fix/incorrect-uptime

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jul 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5355

Problem Summary:

What is changed and how it works?

maybe due to the bug of linux kernel which cause monotonic clock may not be monotonic sometimes. It may cause some operations to fail with "Timeout exceeded: elapsed 18446744073.709553 seconds".Takes previously returned value and returns it again if time stepped back for some reason.
ref to:
https://github.com/ClickHouse/ClickHouse/blob/master/src/Common/Stopwatch.h#L19-L21

result:
image
instance 172.16.5.81:51350 is the patch that add this pr. We can found that uptime grows correctly. However, it still maybe blocked by other thread.

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hongyunyan
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2022
@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as draft July 12, 2022 11:04
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2022
fuzhe1989
fuzhe1989 reviewed Jul 12, 2022
View reviewed changes
@Lloyd-Pottiger
format & address comments
ffea4e0 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 12, 2022

/build

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 12, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 12, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Stopwatch.h                               38                10    73.68%          25                 6    76.00%          95                37    61.05%           8                 4    50.00%
Storages/DeltaMerge/DeltaMergeStore.cpp        1468               538    63.35%          67                 7    89.55%        2058               523    74.59%         854               407    52.34%
Storages/DeltaMerge/DeltaMergeStore.h            41                10    75.61%          19                 2    89.47%          91                24    73.63%          42                 8    80.95%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1547               558    63.93%         111                15    86.49%        2244               584    73.98%         904               419    53.65%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18509      9568             48.31%    208715  96358        53.83%

full coverage report (for internal network access only)

@Lloyd-Pottiger
revert changes in clock_gettime_ns_adjusted
b9053e2 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
format
18de8d7 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger Lloyd-Pottiger marked this pull request as ready for review July 15, 2022 07:13
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 15, 2022

/cc @fuzhe1989 @JaySon-Huang @ywqzzy @flowbehappy

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
ywqzzy
ywqzzy approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 22, 2022

/run-integration-test

1 similar comment
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 23, 2022

/run-integration-test

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 25, 2022

/run-all-tests

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 25, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 25, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Stopwatch.h                               41                10    75.61%          25                 6    76.00%          98                38    61.22%          10                 4    60.00%
Storages/DeltaMerge/DeltaMergeStore.cpp        1488               537    63.91%          67                 5    92.54%        2130               520    75.59%         876               410    53.20%
Storages/DeltaMerge/DeltaMergeStore.h            41                11    73.17%          19                 2    89.47%          91                26    71.43%          42                 9    78.57%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1570               558    64.46%         111                13    88.29%        2319               584    74.82%         928               423    54.42%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18799      9449             49.74%    214182  95452        55.43%

full coverage report (for internal network access only)

@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Jul 25, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022

@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: eafdf2c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 25, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Stopwatch.h                               41                10    75.61%          25                 6    76.00%          98                38    61.22%          10                 4    60.00%
Storages/DeltaMerge/DeltaMergeStore.cpp        1488               545    63.37%          67                 7    89.55%        2130               545    74.41%         876               421    51.94%
Storages/DeltaMerge/DeltaMergeStore.h            41                11    73.17%          19                 2    89.47%          91                26    71.43%          42                 9    78.57%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          1570               566    63.95%         111                15    86.49%        2319               609    73.74%         928               434    53.23%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18799      9452             49.72%    214182  95496        55.41%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit c823138 into pingcap:master Jul 25, 2022
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix/incorrect-uptime branch July 25, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongyunyan hongyunyan hongyunyan approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

+1 more reviewer

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect uptime in grafana when tiflash meets supersize tables

6 participants

@Lloyd-Pottiger @ti-chi-bot @sre-bot @fuzhe1989 @ywqzzy @hongyunyan