Skip to content

fix: format throw data truncated error (#5272)#5341

Closed
ti-chi-bot wants to merge 11 commits intopingcap:release-6.0from
ti-chi-bot:cherry-pick-5272-to-release-6.0
Closed

fix: format throw data truncated error (#5272)#5341
ti-chi-bot wants to merge 11 commits intopingcap:release-6.0from
ti-chi-bot:cherry-pick-5272-to-release-6.0

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jul 11, 2022

This is an automated cherry-pick of #5272

What problem does this PR solve?

Issue Number: close #4891

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual Test:

mysql> select * from test;
+------+--------------------------------------------------------------------+
| id   | value                                                              |
+------+--------------------------------------------------------------------+
|    1 | 9999999999999999999999999999999999999999999999999999999999999.9999 |
+------+--------------------------------------------------------------------+

mysql> select format(value, -3) from test;
+------------------------------------------------------------------------------------+
| format(value, -3)                                                                  |
+------------------------------------------------------------------------------------+
| 10,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000 |
+------------------------------------------------------------------------------------+

mysql> select format(value, 0) from test;
+------------------------------------------------------------------------------------+
| format(value, 0)                                                                   |
+------------------------------------------------------------------------------------+
| 10,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000 |
+------------------------------------------------------------------------------------+

mysql> select format(value, 3) from test;
+----------------------------------------------------------------------------------------+
| format(value, 3)                                                                       |
+----------------------------------------------------------------------------------------+
| 10,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000,000.000 |
+----------------------------------------------------------------------------------------+

mysql> select format(value, 10) from test;
+----------------------------------------------------------------------------------------------+
| format(value, 10)                                                                            |
+----------------------------------------------------------------------------------------------+
| 9,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999,999.9999000000 |
+----------------------------------------------------------------------------------------------+

mysql> explain select format(value, 10) from test;
+---------------------------+---------+--------------+---------------+---------------------------------------+
| id                        | estRows | task         | access object | operator info                         |
+---------------------------+---------+--------------+---------------+---------------------------------------+
| TableReader_11            | 1.00    | root         |               | data:ExchangeSender_10                |
| └─ExchangeSender_10       | 1.00    | mpp[tiflash] |               | ExchangeType: PassThrough             |
|   └─Projection_4          | 1.00    | mpp[tiflash] |               | format(test.test.value, 10)->Column#4 |
|     └─TableFullScan_9     | 1.00    | mpp[tiflash] | table:test    | keep order:false, stats:pseudo        |
+---------------------------+---------+--------------+---------------+---------------------------------------+

mysql> select * from format_test;
+------+----------+
| id   | value    |
+------+----------+
|    1 | 999.9999 |
+------+----------+

mysql> select format(value, -2) from format_test;
+-------------------+
| format(value, -2) |
+-------------------+
| 1,000             |
+-------------------+

mysql> select format(value, 0) from format_test;
+------------------+
| format(value, 0) |
+------------------+
| 1,000            |
+------------------+

mysql> select format(value, 2) from format_test;
+------------------+
| format(value, 2) |
+------------------+
| 1,000.00         |
+------------------+

mysql> select format(value, 10) from format_test;
+-------------------+
| format(value, 10) |
+-------------------+
| 999.9999000000    |
+-------------------+

mysql> explain select format(value, 10) from format_test;
+---------------------------+---------+--------------+-------------------+----------------------------------------------+
| id                        | estRows | task         | access object     | operator info                                |
+---------------------------+---------+--------------+-------------------+----------------------------------------------+
| TableReader_11            | 1.00    | root         |                   | data:ExchangeSender_10                       |
| └─ExchangeSender_10       | 1.00    | mpp[tiflash] |                   | ExchangeType: PassThrough                    |
|   └─Projection_4          | 1.00    | mpp[tiflash] |                   | format(test.format_test.value, 10)->Column#4 |
|     └─TableFullScan_9     | 1.00    | mpp[tiflash] | table:format_test | keep order:false, stats:pseudo               |
+---------------------------+---------+--------------+-------------------+----------------------------------------------+

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that format throw data truncated error

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 11, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.0 labels Jul 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jul 11, 2022

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008 xzhangxian1008 deleted the cherry-pick-5272-to-release-6.0 branch July 11, 2022 09:54
@windtalker
Copy link
Contributor

windtalker commented Jul 14, 2022

Close it since we don't cherry pick fix to release-6.0 branch

@windtalker windtalker closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@xzhangxian1008 xzhangxian1008

Labels

do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @windtalker @xzhangxian1008