Planner: Support Planner Interpreter by SeaRise · Pull Request #5321 · pingcap/tiflash

SeaRise · 2022-07-08T14:10:09Z

What problem does this PR solve?

Issue Number: ref #4739

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Support Planner Interpreter.

ref #4739

ti-chi-bot · 2022-07-08T14:10:12Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

windtalker
ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

SeaRise · 2022-07-08T15:30:48Z

/hold

SeaRise · 2022-07-12T09:31:58Z

/hold cancel

SeaRise · 2022-07-20T04:20:00Z

/label tide/merge-method-rebase

ti-chi-bot · 2022-07-20T04:20:02Z

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

SeaRise · 2022-07-20T07:53:09Z

/label tide/merge-method-rebase

ti-chi-bot · 2022-07-20T07:53:10Z

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

SeaRise · 2022-07-20T08:42:46Z

/label tide/merge-method-rebase

ti-chi-bot · 2022-07-20T08:42:48Z

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

SeaRise · 2022-07-20T09:11:40Z

/label tide/merge-method-rebase

ti-chi-bot · 2022-07-20T09:11:41Z

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

Details

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

SeaRise · 2022-07-21T15:32:36Z

/label tide/merge-method-rebase

ref #4739

SeaRise · 2022-07-25T06:16:41Z

/label tide/merge-method-merge

dbms/src/Flash/Planner/plans/PhysicalJoin.cpp

dbms/src/Flash/Planner/plans/PhysicalTopN.cpp

dbms/src/Flash/Planner/plans/PhysicalWindowSort.cpp

dbms/src/Flash/Planner/FinalizeHelper.cpp

SeaRise · 2022-08-09T10:23:57Z

/run-all-tests

sre-bot · 2022-08-09T11:05:39Z

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19243      9241             51.98%    218764  93968        57.05%

full coverage report (for internal network access only)

dbms/src/Flash/Coprocessor/FineGrainedShuffle.h

dbms/src/Flash/Coprocessor/PushDownFilter.cpp

dbms/src/Flash/Planner/PhysicalPlanHelper.h

ywqzzy · 2022-08-10T01:44:30Z

dbms/src/Flash/Planner/PhysicalPlanVisitor.h

+{
+/// visit physical plan node tree and apply function.
+/// f: (const PhysicalPlanNodePtr &) -> bool, return true to continue visit.
+template <typename FF>


Maybe in future, we can use visitor pattern in PhysicalPlanNode.

dbms/src/Core/ColumnsWithTypeAndName.h

ywqzzy

LGTM

dbms/src/Flash/Planner/plans/PhysicalUnary.h

dbms/src/Flash/Planner/plans/PhysicalBinary.h

Co-authored-by: yanweiqi <592838129@qq.com>

SeaRise · 2022-08-10T07:14:36Z

/merge

ti-chi-bot · 2022-08-10T07:14:37Z

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-08-10T07:14:39Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: fb13269

ti-chi-bot · 2022-08-10T07:14:52Z

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-08-10T07:56:01Z

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
19245      9240             51.99%    218797  93992        57.04%

full coverage report (for internal network access only)

SeaRise added 3 commits June 8, 2022 12:20

Feature Branch: merge master to planner_refactory branch (#5034)

44c4400

ref #4739

Introduce physical plan and add switch (#4820)

aabe213

ref #4739

Planner: Support common physical plans (#5143)

07b1b20

ref #4739

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2022

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022

SeaRise mentioned this pull request Jul 12, 2022

interpreter planner refactor #4739

Closed

13 tasks

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2022

SeaRise added 2 commits July 18, 2022 14:36

merge master to planner_refactory

d027469

merge master to Feature branch: planner_refactory ref #4739

7693e14

SeaRise force-pushed the planner_refactory branch from 05fd9bd to 7693e14 Compare July 18, 2022 10:14

merge master to planner_refactory

467fb68

ti-chi-bot added the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jul 21, 2022

Feature Branch: merge master to planner_refactory (#5426)

aa20f61

ref #4739

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2022

SeaRise removed the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jul 25, 2022

ywqzzy reviewed Aug 9, 2022

View reviewed changes

ywqzzy self-requested a review August 9, 2022 09:06

address comments

ca94ba0

ywqzzy reviewed Aug 10, 2022

View reviewed changes

ywqzzy self-requested a review August 10, 2022 02:15

SeaRise added 2 commits August 10, 2022 12:26

address comments

98581c2

fix clang tidy

dca94c6

ywqzzy reviewed Aug 10, 2022

View reviewed changes

dbms/src/Core/ColumnsWithTypeAndName.h Outdated Show resolved Hide resolved

SeaRise commented Aug 10, 2022

View reviewed changes

dbms/src/Core/ColumnsWithTypeAndName.h Outdated Show resolved Hide resolved

Update dbms/src/Core/ColumnsWithTypeAndName.h

2c12eca

SeaRise requested a review from ywqzzy August 10, 2022 06:45

ywqzzy approved these changes Aug 10, 2022

View reviewed changes

dbms/src/Flash/Planner/plans/PhysicalUnary.h Outdated Show resolved Hide resolved

dbms/src/Flash/Planner/plans/PhysicalBinary.h Outdated Show resolved Hide resolved

dbms/src/Flash/Planner/plans/PhysicalBinary.h Outdated Show resolved Hide resolved

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022

SeaRise and others added 3 commits August 10, 2022 15:13

Update dbms/src/Flash/Planner/plans/PhysicalBinary.h

28ae5f0

Co-authored-by: yanweiqi <592838129@qq.com>

Update dbms/src/Flash/Planner/plans/PhysicalUnary.h

9f3bbd9

Co-authored-by: yanweiqi <592838129@qq.com>

Update dbms/src/Flash/Planner/plans/PhysicalBinary.h

fb13269

Co-authored-by: yanweiqi <592838129@qq.com>

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 10, 2022

Merge branch 'master' into planner_refactory

f1b9c35

ti-chi-bot merged commit f470b46 into master Aug 10, 2022

JaySon-Huang deleted the planner_refactory branch August 10, 2022 11:27

JaySon-Huang mentioned this pull request Aug 10, 2022

Fix compile error under MacOS #5591

Merged

12 tasks

SeaRise mentioned this pull request Aug 15, 2022

The number of threads of agg in explain analyze is not correct #5314

Closed

Conversation

SeaRise commented Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SeaRise commented Jul 8, 2022

Uh oh!

SeaRise commented Jul 12, 2022

Uh oh!

SeaRise commented Jul 20, 2022

Uh oh!

ti-chi-bot commented Jul 20, 2022

Uh oh!

SeaRise commented Jul 20, 2022

Uh oh!

ti-chi-bot commented Jul 20, 2022

Uh oh!

SeaRise commented Jul 20, 2022

Uh oh!

ti-chi-bot commented Jul 20, 2022

Uh oh!

SeaRise commented Jul 20, 2022

Uh oh!

ti-chi-bot commented Jul 20, 2022

Uh oh!

SeaRise commented Jul 21, 2022

Uh oh!

SeaRise commented Jul 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SeaRise commented Aug 9, 2022

Uh oh!

sre-bot commented Aug 9, 2022

Coverage for changed files

Coverage summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ywqzzy Aug 10, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ywqzzy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SeaRise commented Aug 10, 2022

Uh oh!

ti-chi-bot commented Aug 10, 2022

Uh oh!

ti-chi-bot commented Aug 10, 2022

Uh oh!

ti-chi-bot commented Aug 10, 2022

Uh oh!

sre-bot commented Aug 10, 2022

Coverage for changed files

Coverage summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SeaRise commented Jul 8, 2022 •

edited

Loading

ti-chi-bot commented Jul 8, 2022 •

edited

Loading