DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) by ti-chi-bot · Pull Request #5193 · pingcap/tiflash

ti-chi-bot · 2022-06-22T09:16:32Z

This is an automated cherry-pick of #5166

What problem does this PR solve?

Issue Number: close #5154

Problem Summary:

What is changed and how it works?

in decodingSchemaSnapshot, we use column name instead of offset to find cluster index id of the common handle. Because in tiflash, we don't update the indexinfo of table_info except rename ddl action. Thus, the offset of tidb_table_info is not correctly in sometimes.

Besides, I add two DDL tests based on issue #5154, concerning about clustered index.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Fix the TiFlash crash issue that occurs after dropping a column of a table with clustered indexes under some situations.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2022-06-22T09:16:34Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JaySon-Huang
lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

fix merge master error

fix format

hongyunyan · 2022-06-23T06:48:29Z

/rebuild

fix clang tidy

hongyunyan · 2022-06-23T10:26:35Z

/run-all-tests

hongyunyan · 2022-06-23T10:28:34Z

/run-unit-tests

hongyunyan · 2022-06-23T13:00:02Z

/run-all-tests

sre-bot · 2022-06-23T13:23:32Z

Coverage for changed files

Filename                                                                  Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Core/Block.cpp                                                                218                79    63.76%          44                10    77.27%         383               162    57.70%         142                61    57.04%
Debug/MockTiDB.cpp                                                            154               150     2.60%          35                33     5.71%         481               463     3.74%         102               101     0.98%
Debug/dbgFuncMockRaftCommand.cpp                                               28                28     0.00%           4                 4     0.00%         183               183     0.00%          16                16     0.00%
Debug/dbgFuncMockRaftSnapshot.cpp                                             174               162     6.90%          23                15    34.78%         553               505     8.68%         118               116     1.69%
Debug/dbgFuncRegion.cpp                                                        95                95     0.00%          13                13     0.00%         253               253     0.00%          64                64     0.00%
Debug/dbgTools.cpp                                                            168               166     1.19%          24                22     8.33%         459               446     2.83%         182               182     0.00%
Storages/Transaction/DecodingStorageSchemaSnapshot.h                           33                 1    96.97%           1                 0   100.00%          63                 1    98.41%          26                 2    92.31%
Storages/Transaction/RegionBlockReader.cpp                                     82                26    68.29%           3                 0   100.00%         164                25    84.76%          60                24    60.00%
Storages/Transaction/TiDB.cpp                                                 480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
Storages/Transaction/TiDB.h                                                    20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
Storages/Transaction/TiKVRecordFormat.h                                        99                10    89.90%          37                 1    97.30%         263                18    93.16%          44                 5    88.64%
Storages/Transaction/tests/RowCodecTestUtils.h                                 76                 4    94.74%          14                 0   100.00%         168                 1    99.40%          30                 2    93.33%
Storages/Transaction/tests/gtest_decoding_storage_schema_snapshot.cpp         251                36    85.66%           3                 0   100.00%          25                 0   100.00%          72                36    50.00%
Storages/Transaction/tests/gtest_region_block_reader.cpp                      593                99    83.31%          21                 0   100.00%         256                 4    98.44%         208                87    58.17%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                        2471              1129    54.31%         283               114    59.72%        4120              2458    40.34%        1404               850    39.46%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18242      9787             46.35%    204444  98043        52.04%

full coverage report (for internal network access only)

JaySon-Huang

LGTM

JaySon-Huang · 2022-08-17T10:37:20Z

/merge

ti-chi-bot · 2022-08-17T10:37:23Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-08-17T10:37:24Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 1fd73e4

ti-chi-bot · 2022-08-17T10:37:37Z

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-08-17T11:03:55Z

Coverage for changed files

Filename                                                                  Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Core/Block.cpp                                                                218                79    63.76%          44                10    77.27%         383               162    57.70%         142                61    57.04%
Debug/MockTiDB.cpp                                                            154               150     2.60%          35                33     5.71%         481               463     3.74%         102               101     0.98%
Debug/dbgFuncMockRaftCommand.cpp                                               28                28     0.00%           4                 4     0.00%         183               183     0.00%          16                16     0.00%
Debug/dbgFuncMockRaftSnapshot.cpp                                             174               162     6.90%          23                15    34.78%         553               505     8.68%         118               116     1.69%
Debug/dbgFuncRegion.cpp                                                        95                95     0.00%          13                13     0.00%         253               253     0.00%          64                64     0.00%
Debug/dbgTools.cpp                                                            168               166     1.19%          24                22     8.33%         459               446     2.83%         182               182     0.00%
Storages/Transaction/DecodingStorageSchemaSnapshot.h                           33                 1    96.97%           1                 0   100.00%          63                 1    98.41%          26                 2    92.31%
Storages/Transaction/RegionBlockReader.cpp                                     82                26    68.29%           3                 0   100.00%         164                25    84.76%          60                24    60.00%
Storages/Transaction/TiDB.cpp                                                 480               266    44.58%          45                13    71.11%         853               394    53.81%         334               148    55.69%
Storages/Transaction/TiDB.h                                                    20                 7    65.00%          16                 3    81.25%          16                 3    81.25%           6                 6     0.00%
Storages/Transaction/TiKVRecordFormat.h                                        99                10    89.90%          37                 1    97.30%         263                18    93.16%          44                 5    88.64%
Storages/Transaction/tests/RowCodecTestUtils.h                                 76                 4    94.74%          14                 0   100.00%         168                 1    99.40%          30                 2    93.33%
Storages/Transaction/tests/gtest_decoding_storage_schema_snapshot.cpp         251                36    85.66%           3                 0   100.00%          25                 0   100.00%          72                36    50.00%
Storages/Transaction/tests/gtest_region_block_reader.cpp                      593                99    83.31%          21                 0   100.00%         256                 4    98.44%         208                87    58.17%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                        2471              1129    54.31%         283               114    59.72%        4120              2458    40.34%        1404               850    39.46%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18249      9783             46.39%    204628  98036        52.09%

full coverage report (for internal network access only)

This is an automated cherry-pick of pingcap#5166

787a14d

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jun 22, 2022

DDL: Use Column Name Instead of Offset to Find the common handle cluster index #5166

Merged

12 tasks

VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 22, 2022

ti-chi-bot added do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved labels Jun 22, 2022

hongyunyan and others added 4 commits June 23, 2022 11:19

fix merge master error

2536235

Merge pull request #3 from hongyunyan/hongyunyan_fix_6.1

9ce458e

fix merge master error

fix format

69f967e

Merge pull request #5 from hongyunyan/hongyunyan_fix_6.1

35c615f

fix format

hongyunyan added 2 commits June 23, 2022 17:57

fix clang tidy

532e35b

Merge pull request #9 from hongyunyan/hongyunyan_fix_6.1

1fd73e4

fix clang tidy

lidezhu approved these changes Jun 23, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2022

JaySon-Huang approved these changes Jun 23, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2022

Merge branch 'release-6.1' into cherry-pick-5166-to-release-6.1

5718a93

ti-chi-bot merged commit 623164f into pingcap:release-6.1 Aug 17, 2022

jayl1e added this to the v6.1.1 milestone Aug 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166)#5193

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166)#5193
ti-chi-bot merged 8 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-5166-to-release-6.1

ti-chi-bot commented Jun 22, 2022

Uh oh!

ti-chi-bot commented Jun 22, 2022 •

edited

Loading

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

sre-bot commented Jun 23, 2022

Uh oh!

JaySon-Huang left a comment

Uh oh!

JaySon-Huang commented Aug 17, 2022

Uh oh!

ti-chi-bot commented Aug 17, 2022

Uh oh!

ti-chi-bot commented Aug 17, 2022

Uh oh!

ti-chi-bot commented Aug 17, 2022

Uh oh!

sre-bot commented Aug 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

ti-chi-bot commented Jun 22, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

hongyunyan commented Jun 23, 2022

Uh oh!

sre-bot commented Jun 23, 2022

Coverage for changed files

Coverage summary

Uh oh!

JaySon-Huang left a comment

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang commented Aug 17, 2022

Uh oh!

ti-chi-bot commented Aug 17, 2022

Uh oh!

ti-chi-bot commented Aug 17, 2022

Uh oh!

ti-chi-bot commented Aug 17, 2022

Uh oh!

sre-bot commented Aug 17, 2022

Coverage for changed files

Coverage summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ti-chi-bot commented Jun 22, 2022 •

edited

Loading