Skip to content

increase bg gc check interval (#5056)#5065

Merged
ti-chi-bot merged 3 commits intopingcap:release-5.3from
ti-chi-bot:cherry-pick-5056-to-release-5.3
Jun 14, 2022
Merged

increase bg gc check interval (#5056)#5065
ti-chi-bot merged 3 commits intopingcap:release-5.3from
ti-chi-bot:cherry-pick-5056-to-release-5.3

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 3, 2022

This is an automated cherry-pick of #5056

What problem does this PR solve?

Issue Number: close #5057

Problem Summary: The background gc check interval is too short and may consume some unnecessary resource consumption.

What is changed and how it works?

Increase background gc check interval from 5 seconds to 60 seconds.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-5.3 labels Jun 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 14, 2022
@flowbehappy flowbehappy self-requested a review June 14, 2022 03:11
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 14, 2022
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 14, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 14, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 14, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: dcbadfc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 14, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 14, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 14, 2022

lines: 36.0% (42938 out of 119361)
branches: 5.4% (65794 out of 1221590)

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 14, 2022

lines: 35.9% (42866 out of 119299)
branches: 5.4% (65673 out of 1221206)

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 14, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 35cc201 into pingcap:release-5.3 Jun 14, 2022
@heibaijian heibaijian added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@lidezhu lidezhu

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3

Projects

None yet

Milestone

v5.3.2

Development

Successfully merging this pull request may close these issues.

7 participants

@ti-chi-bot @JaySon-Huang @sre-bot @flowbehappy @VelocityLight @heibaijian @lidezhu