Skip to content

Test: Mock Input columns for operator tests#5041

Merged
ti-chi-bot merged 32 commits intopingcap:masterfrom
ywqdev:mock_stream_inputblock
Jun 8, 2022
Merged

Test: Mock Input columns for operator tests#5041
ti-chi-bot merged 32 commits intopingcap:masterfrom
ywqdev:mock_stream_inputblock

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Jun 1, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • mengxin9014

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2022
@SeaRise SeaRise self-requested a review June 1, 2022 07:11
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jun 1, 2022

/cc @xzhangxian1008

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022

@ywqzzy: GitHub didn't allow me to request PR reviews from the following users: xzhangxian1008.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @xzhangxian1008

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy ywqzzy mentioned this pull request Jun 1, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 1, 2022
@ywqzzy ywqzzy changed the title [WIP]Test: Mock Input columns for operator tests(poc) Test: Mock Input columns for operator tests Jun 1, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2022
@ywqzzy ywqzzy mentioned this pull request Jun 1, 2022
Closed
54 tasks
SeaRise
SeaRise reviewed Jun 1, 2022
View reviewed changes
@ywqzzy ywqzzy changed the title Test: Mock Input columns for operator tests [WIP] Test: Mock Input columns for operator tests Jun 1, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2022
SeaRise
SeaRise reviewed Jun 2, 2022
View reviewed changes
SeaRise
SeaRise reviewed Jun 2, 2022
View reviewed changes
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 7, 2022

Coverage for changed files

Filename                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/MockExchangeReceiverInputStream.cpp          17                 0   100.00%           4                 0   100.00%          40                 1    97.50%          12                 1    91.67%
DataStreams/MockExchangeReceiverInputStream.h             2                 0   100.00%           2                 0   100.00%           4                 0   100.00%           0                 0         -
Flash/Coprocessor/DAGContext.cpp                        104                60    42.31%          28                13    53.57%         235               120    48.94%          74                54    27.03%
Flash/Coprocessor/DAGContext.h                           39                11    71.79%          30                 9    70.00%          85                29    65.88%          12                 6    50.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp          261                87    66.67%          39                 4    89.74%         620               127    79.52%         164                60    63.41%
Flash/Coprocessor/DAGQueryBlockInterpreter.h              2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
Flash/Coprocessor/InterpreterDAG.cpp                     27                 4    85.19%           5                 0   100.00%          60                 8    86.67%          20                 7    65.00%
Flash/tests/gtest_executor.cpp                          103                76    26.21%           7                 0   100.00%         189                 0   100.00%          16                16     0.00%
Flash/tests/gtest_interpreter.cpp                        82                38    53.66%           3                 0   100.00%         339                 0   100.00%           8                 8     0.00%
TestUtils/InterpreterTestUtils.cpp                       67                 9    86.57%          10                 1    90.00%          84                 6    92.86%          26                 7    73.08%
TestUtils/InterpreterTestUtils.h                          2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
TestUtils/mockExecutor.cpp                               70                14    80.00%          43                12    72.09%         266                57    78.57%          32                 2    93.75%
TestUtils/mockExecutor.h                                  6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   782               300    61.64%         181                40    77.90%        1944               351    81.94%         364               161    55.77%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18308      9642             47.33%    205331  96604        52.95%

full coverage report (for internal network access only)

@ywqzzy ywqzzy requested a review from windtalker June 7, 2022 08:04
SeaRise
SeaRise reviewed Jun 7, 2022
View reviewed changes
@SeaRise SeaRise self-requested a review June 7, 2022 09:57
SeaRise
SeaRise approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent job!
LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2022
@SeaRise SeaRise mentioned this pull request Jun 7, 2022
Merged
12 tasks
@ywqzzy ywqzzy requested review from guo-shaoge and mengxin9014 June 7, 2022 10:42
mengxin9014
mengxin9014 reviewed Jun 7, 2022
View reviewed changes
mengxin9014
mengxin9014 reviewed Jun 7, 2022
View reviewed changes
mengxin9014
mengxin9014 reviewed Jun 7, 2022
View reviewed changes
dbms/src/TestUtils/ExecutorTestUtils.cpp
try
{
DB::registerFunctions();
DB::registerAggregateFunctions();
Copy link
Contributor

@mengxin9014 mengxin9014 Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add registerWindowFunctions?

Copy link
Contributor Author

@ywqzzy ywqzzy Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here may have potential bug in unit test if we run function related test and MockExecutor test simultaneously(#5081), I wonder if I can fix it in another pr.

@ywqzzy ywqzzy requested a review from mengxin9014 June 8, 2022 02:21
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 8, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jun 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 38e6a7a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 8, 2022

Coverage for changed files

Filename                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/MockExchangeReceiverInputStream.cpp          17                 0   100.00%           4                 0   100.00%          40                 1    97.50%          12                 1    91.67%
DataStreams/MockExchangeReceiverInputStream.h             2                 0   100.00%           2                 0   100.00%           4                 0   100.00%           0                 0         -
Flash/Coprocessor/DAGContext.cpp                        104                60    42.31%          28                13    53.57%         235               120    48.94%          74                54    27.03%
Flash/Coprocessor/DAGContext.h                           39                11    71.79%          30                 9    70.00%          85                29    65.88%          12                 6    50.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp          239                80    66.53%          38                 4    89.47%         592               127    78.55%         150                57    62.00%
Flash/Coprocessor/InterpreterDAG.cpp                     28                 7    75.00%           5                 0   100.00%          62                11    82.26%          20                 8    60.00%
Flash/Coprocessor/MockSourceStream.h                     33                14    57.58%           1                 0   100.00%          34                 0   100.00%          18                 6    66.67%
Flash/tests/gtest_executor.cpp                          101                76    24.75%           5                 0   100.00%         182                 0   100.00%          16                16     0.00%
Flash/tests/gtest_interpreter.cpp                        82                38    53.66%           3                 0   100.00%         339                 0   100.00%           8                 8     0.00%
TestUtils/ExecutorTestUtils.cpp                          67                 9    86.57%          10                 1    90.00%          83                 6    92.77%          26                 7    73.08%
TestUtils/ExecutorTestUtils.h                             5                 0   100.00%           5                 0   100.00%          14                 0   100.00%           0                 0         -
TestUtils/mockExecutor.cpp                               70                14    80.00%          43                12    72.09%         266                57    78.57%          32                 2    93.75%
TestUtils/mockExecutor.h                                  6                 1    83.33%           6                 1    83.33%          15                 3    80.00%           0                 0         -
TestUtils/tests/gtest_mock_executors.cpp                238               171    28.15%          10                 0   100.00%         204                 0   100.00%          36                36     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                  1031               481    53.35%         190                40    78.95%        2155               354    83.57%         404               201    50.25%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18311      9641             47.35%    205470  96552        53.01%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit fdab3f5 into pingcap:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker Awaiting requested review from windtalker

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

2 more reviewers

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ywqzzy @ti-chi-bot @SeaRise @sre-bot @mengxin9014