Skip to content

enable new function test framework by default#5029

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
windtalker:use_new_function_unit_test_framework
Jun 1, 2022
Merged

enable new function test framework by default#5029
ti-chi-bot merged 6 commits intopingcap:masterfrom
windtalker:use_new_function_unit_test_framework

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented May 30, 2022

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: ref #4830

Problem Summary:

What is changed and how it works?

Currently, function unit test will create function directly but DAGExpressionAnalyzer, it may add some rewrite when compiling function, #4861 add a new function unit test framework, which will convert columns to tipb expression first, and then use DAGExpressionAnalyzer to build the function. This pr enable this new function test framework by default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
enable new function test framework by default
7fdacc1 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 30, 2022
@windtalker
fix
18fb602 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker windtalker requested review from SeaRise and ywqzzy May 30, 2022 06:28
SeaRise
SeaRise reviewed May 30, 2022
View reviewed changes
@SeaRise SeaRise self-requested a review May 30, 2022 08:26
ywqzzy
ywqzzy approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 30, 2022
@windtalker
address comments
f73b611 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
SeaRise
SeaRise reviewed May 30, 2022
View reviewed changes
windtalker added 2 commits May 31, 2022 11:34
@windtalker
add more tests
23cd8fa 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@windtalker
fix
7ddd251 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@SeaRise SeaRise self-requested a review May 31, 2022 07:02
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2022
@windtalker
Copy link
Contributor Author

windtalker commented Jun 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7ddd251

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 1, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9734             46.76%    204966  97573        52.40%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 1, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18291      9749             46.70%    204892  97788        52.27%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 380f6cd into pingcap:master Jun 1, 2022
@windtalker windtalker deleted the use_new_function_unit_test_framework branch June 1, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SeaRise SeaRise SeaRise approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@windtalker @ti-chi-bot @sre-bot @SeaRise @ywqzzy