Skip to content

Fix unstable ut in the master branch#5024

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
hehechen:fix_ut
May 27, 2022
Merged

Fix unstable ut in the master branch#5024
ti-chi-bot merged 3 commits intopingcap:masterfrom
hehechen:fix_ut

Conversation

@hehechen
Copy link
Contributor

@hehechen hehechen commented May 27, 2022 •
edited by JaySon-Huang
Loading

Signed-off-by: hehechen awd123456sss@gmail.com

What problem does this PR solve?

Issue Number: close #5023

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@hehechen
fix ut
17d7af1 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • Lloyd-Pottiger
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2022
@hehechen
Copy link
Contributor Author

hehechen commented May 27, 2022

/run-unit-test

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 27, 2022

/run-unit-test

@JaySon-Huang JaySon-Huang changed the title fix ut Fix unstable ut in the master branch May 27, 2022
@hehechen hehechen requested review from JaySon-Huang and jiaqizho May 27, 2022 11:31
@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                                                                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/TestUtils/TiFlashTestEnv.cpp          25                 4    84.00%           4                 0   100.00%          65                 9    86.15%          14                 6    57.14%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     25                 4    84.00%           4                 0   100.00%          65                 9    86.15%          14                 6    57.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18277      9788             46.45%    204804  98189        52.06%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@hehechen
Copy link
Contributor Author

hehechen commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 50f45bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022

@hehechen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                                                                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/TestUtils/TiFlashTestEnv.cpp          25                 4    84.00%           4                 0   100.00%          65                 9    86.15%          14                 6    57.14%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                     25                 4    84.00%           4                 0   100.00%          65                 9    86.15%          14                 6    57.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18285      9796             46.43%    204852  98208        52.06%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 7dff463 into pingcap:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

+1 more reviewer

@jiaqizho jiaqizho jiaqizho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unstable unit tests of DeltaTree

6 participants

@hehechen @ti-chi-bot @JaySon-Huang @sre-bot @jiaqizho @Lloyd-Pottiger