Skip to content

Add mix mode UT#5012

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
hehechen:add_ps_ut
May 31, 2022
Merged

Add mix mode UT#5012
ti-chi-bot merged 3 commits intopingcap:masterfrom
hehechen:add_ps_ut

Conversation

@hehechen
Copy link
Contributor

@hehechen hehechen commented May 27, 2022 •
edited
Loading

Signed-off-by: hehechen awd123456sss@gmail.com

What problem does this PR solve?

add mix mode ut
Issue Number: close #5028

Problem Summary:

What is changed and how it works?

add mix mode ut

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jiaqizho
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2022
@hehechen hehechen requested a review from jiaqizho May 27, 2022 02:32
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2022
hehechen added 2 commits May 27, 2022 18:12
@hehechen
add mix mode ut
6586b33 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
test truncate blob
ee049b9 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen hehechen changed the title [WIP]add mix mode ut Add mix mode UT May 30, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
@hehechen
Copy link
Contributor Author

hehechen commented May 30, 2022

/run-all-tests

@hehechen hehechen requested review from JaySon-Huang and lidezhu May 30, 2022 03:50
@hehechen
Copy link
Contributor Author

hehechen commented May 30, 2022

/rebuild

@sre-bot
Copy link
Collaborator

sre-bot commented May 30, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
gtest_page_storage.cpp                 3741              1299    65.28%          46                 7    84.78%        1119               154    86.24%        1176               666    43.37%
gtest_page_storage_mix_mode.cpp        2432               662    72.78%          21                 0   100.00%         725                21    97.10%         708               365    48.45%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  6173              1961    68.23%          67                 7    89.55%        1844               175    90.51%        1884              1031    45.28%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18284      9784             46.49%    205071  98083        52.17%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 30, 2022

/run-integration-test

1 similar comment
@hehechen
Copy link
Contributor Author

hehechen commented May 30, 2022

/run-integration-test

lidezhu
lidezhu approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2022
jiaqizho
jiaqizho approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 31, 2022
@hehechen
Copy link
Contributor Author

hehechen commented May 31, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: ee049b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 31, 2022

@hehechen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 31, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
gtest_page_storage.cpp                 3741              1299    65.28%          46                 7    84.78%        1119               154    86.24%        1176               666    43.37%
gtest_page_storage_mix_mode.cpp        2432               662    72.78%          21                 0   100.00%         725                21    97.10%         708               365    48.45%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  6173              1961    68.23%          67                 7    89.55%        1844               175    90.51%        1884              1031    45.28%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9779             46.51%    204997  97990        52.20%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit a0ed1a6 into pingcap:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidezhu lidezhu lidezhu approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

+1 more reviewer

@jiaqizho jiaqizho jiaqizho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add more UT for PageStorage V3 MixMode

6 participants

@hehechen @ti-chi-bot @sre-bot @JaySon-Huang @jiaqizho @lidezhu