Skip to content

Add mutex to protect exchange receiver's async client (#5008)#5010

Merged
ti-chi-bot merged 6 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-5008-to-release-6.1
May 27, 2022
Merged

Add mutex to protect exchange receiver's async client (#5008)#5010
ti-chi-bot merged 6 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-5008-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 26, 2022

This is an automated cherry-pick of #5008

What problem does this PR solve?

Issue Number: close #4977

Problem Summary:

What is changed and how it works?

For ExchangeReceiver's async client mode, AsyncRequestHandler instance is used to handle async client request and rsp. And it is shared between grpc and reactor thread. However, when handler is creating, there is a little chance that grpc thread get the instance before the creation is completed. So there is chance that #4977 would happen.
Now this is noticed only when makeAsyncReader failed and retried.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

yibin87 added 6 commits May 26, 2022 14:27
@yibin87 @ti-chi-bot
Add to_seconds support for tiflash
2a92312 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Fix format issue
b911915 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Add mutex lock to protect async reciever async reader
4d0df31 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Fix a rebase issue
53ab666 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Change raw pointer to unique ptr
e4e892d 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 @ti-chi-bot
Fix format issue
1791de8 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request May 26, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels May 26, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label May 26, 2022
windtalker
windtalker approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
yibin87
yibin87 approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@windtalker
Copy link
Contributor

windtalker commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 1791de8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@windtalker
Copy link
Contributor

windtalker commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented May 27, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 27, 2022

Coverage for changed files

Filename                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/ExchangeReceiver.cpp          320               320     0.00%          32                32     0.00%         486               486     0.00%         192               192     0.00%
Functions/FunctionsDateTime.cpp          68                31    54.41%          14                 3    78.57%         197                58    70.56%          48                25    47.92%
Functions/FunctionsDateTime.h          1061               628    40.81%         328               211    35.67%        2005              1196    40.35%         516               327    36.63%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                  1449               979    32.44%         374               246    34.22%        2688              1740    35.27%         756               544    28.04%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18231      9783             46.34%    204181  97999        52.00%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit b34873a into pingcap:release-6.1 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees

@yibin87 yibin87

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @windtalker @sre-bot @yibin87 @VelocityLight