Remove useless code#5004
Merged
ti-chi-bot merged 14 commits intopingcap:masterfrom May 31, 2022
hongyunyan:hongyunyan_remove_uselss_code
Merged
Remove useless code#5004ti-chi-bot merged 14 commits intopingcap:masterfrom hongyunyan:hongyunyan_remove_uselss_code
ti-chi-bot merged 14 commits intopingcap:masterfrom
hongyunyan:hongyunyan_remove_uselss_code
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Collaborator
|
|
Contributor
|
Also should remove the tiflash/etc/config-template.toml Lines 133 to 136 in ac29da0 |
| return data_list_to_remove; | ||
| } | ||
|
|
||
| RegionID RegionTable::pickRegionToFlush() |
Contributor
There was a problem hiding this comment.
After removing this method, can we also remove dirty_regions and shouldFlush?
Contributor
Author
There was a problem hiding this comment.
We can remove shouldFlush function，but dirty_regions is still be used in function like tryFlushRegion
Contributor
Author
|
/run-unit-test |
Contributor
Author
|
/run-unit-test |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-integration-test |
Member
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-unit-test |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
…ngyunyan/tiflash into hongyunyan_remove_uselss_code
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Lloyd-Pottiger
approved these changes
May 31, 2022
Contributor
|
/merge |
Member
|
@Lloyd-Pottiger: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: a5f1ae7 |
Contributor
Author
|
/merge |
Member
|
@hongyunyan: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
@hongyunyan: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4998
Problem Summary:
Remove parts of codes that are not in use.
What is changed and how it works?
Remove parts of codes that are not in use, Including :
Check List
Tests
Side effects
Documentation
Release note