Skip to content

Add a force transfrom meta from v2 to v3#4873

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
jiaqizho:translate-meta-v2-to-v3
May 13, 2022
Merged

Add a force transfrom meta from v2 to v3#4873
ti-chi-bot merged 11 commits intopingcap:masterfrom
jiaqizho:translate-meta-v2-to-v3

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented May 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

  • After user running in mix mode and do the delta merge.
  • Meta won't be del, and table won't change to the ONLY_V3

What is changed and how it works?

  • Force transform the meta from V2 to V3 when storagepool restored.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2022
jiaqizho
jiaqizho commented May 12, 2022
View reviewed changes
@jiaqizho jiaqizho changed the title Add a force transfrom from v2 to v3 Add a force transfrom meta from v2 to v3 May 12, 2022
@jiaqizho jiaqizho requested a review from JaySon-Huang May 12, 2022 06:51
@JaySon-Huang JaySon-Huang requested a review from lidezhu May 12, 2022 09:25
JaySon-Huang
JaySon-Huang reviewed May 12, 2022
View reviewed changes
lidezhu
lidezhu approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2022
JaySon-Huang
JaySon-Huang reviewed May 13, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed May 13, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a354352

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp         173                67    61.27%          29                 6    79.31%         433               167    61.43%         114                56    50.88%
DeltaMerge/StoragePool.h            21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Page/Page.h                         61                 6    90.16%          15                 1    93.33%          79                16    79.75%          38                12    68.42%
Page/PageStorage.cpp               140                39    72.14%          47                 8    82.98%         387               119    69.25%         104                35    66.35%
Page/PageStorage.h                  19                 1    94.74%          19                 1    94.74%          85                 3    96.47%           0                 0         -
Page/V3/PageEntry.h                 18                 2    88.89%           6                 0   100.00%          38                 8    78.95%           8                 2    75.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              432               119    72.45%         131                17    87.02%        1078               331    69.29%         270               108    60.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18155      9820             45.91%    202713  98375        51.47%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp         173                67    61.27%          29                 6    79.31%         433               167    61.43%         114                56    50.88%
DeltaMerge/StoragePool.h            21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Page/Page.h                         61                 6    90.16%          15                 1    93.33%          79                16    79.75%          38                12    68.42%
Page/PageStorage.cpp               140                39    72.14%          47                 8    82.98%         387               119    69.25%         104                35    66.35%
Page/PageStorage.h                  19                 1    94.74%          19                 1    94.74%          85                 3    96.47%           0                 0         -
Page/V3/PageEntry.h                 18                 2    88.89%           6                 0   100.00%          38                 8    78.95%           8                 2    75.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              432               119    72.45%         131                17    87.02%        1078               331    69.29%         270               108    60.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18124      9788             45.99%    202263  97921        51.59%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp         173                67    61.27%          29                 6    79.31%         433               167    61.43%         114                56    50.88%
DeltaMerge/StoragePool.h            21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Page/Page.h                         61                 6    90.16%          15                 1    93.33%          79                16    79.75%          38                12    68.42%
Page/PageStorage.cpp               140                39    72.14%          47                 8    82.98%         387               119    69.25%         104                35    66.35%
Page/PageStorage.h                  19                 1    94.74%          19                 1    94.74%          85                 3    96.47%           0                 0         -
Page/V3/PageEntry.h                 18                 2    88.89%           6                 0   100.00%          38                 8    78.95%           8                 2    75.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              432               119    72.45%         131                17    87.02%        1078               331    69.29%         270               108    60.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18124      9788             45.99%    202269  97910        51.59%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp         173                67    61.27%          29                 6    79.31%         433               167    61.43%         114                56    50.88%
DeltaMerge/StoragePool.h            21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Page/Page.h                         61                 6    90.16%          15                 1    93.33%          79                16    79.75%          38                12    68.42%
Page/PageStorage.cpp               140                39    72.14%          47                 8    82.98%         387               119    69.25%         104                35    66.35%
Page/PageStorage.h                  19                 1    94.74%          19                 1    94.74%          85                 3    96.47%           0                 0         -
Page/V3/PageEntry.h                 18                 2    88.89%           6                 0   100.00%          38                 8    78.95%           8                 2    75.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              432               119    72.45%         131                17    87.02%        1078               331    69.29%         270               108    60.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18124      9788             45.99%    202269  97912        51.59%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jiaqizho
Copy link
Contributor Author

jiaqizho commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp         173                67    61.27%          29                 6    79.31%         433               167    61.43%         114                56    50.88%
DeltaMerge/StoragePool.h            21                 4    80.95%          15                 1    93.33%          56                18    67.86%           6                 3    50.00%
Page/Page.h                         61                 6    90.16%          15                 1    93.33%          79                16    79.75%          38                12    68.42%
Page/PageStorage.cpp               140                39    72.14%          47                 8    82.98%         387               119    69.25%         104                35    66.35%
Page/PageStorage.h                  19                 1    94.74%          19                 1    94.74%          85                 3    96.47%           0                 0         -
Page/V3/PageEntry.h                 18                 2    88.89%           6                 0   100.00%          38                 8    78.95%           8                 2    75.00%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              432               119    72.45%         131                17    87.02%        1078               331    69.29%         270               108    60.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18124      9788             45.99%    202269  97919        51.59%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 9e46e67 into pingcap:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@lidezhu lidezhu lidezhu approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jiaqizho @ti-chi-bot @JaySon-Huang @sre-bot @lidezhu