Skip to content

Interpreter: Run interpreter test with exchange executors#4858

Merged
ti-chi-bot merged 14 commits intopingcap:masterfrom
ywqdev:run_interpreter_with_exchange
May 17, 2022
Merged

Interpreter: Run interpreter test with exchange executors#4858
ti-chi-bot merged 14 commits intopingcap:masterfrom
ywqdev:run_interpreter_with_exchange

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented May 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4609

Problem Summary:

What is changed and how it works?

Mock ExchangeSender/ReceiverInputStreams for interpreter tests. Only use mock data, don't care about network and region releted info.
After this pr, one can use mockExecutor to mock all DAGRequest to run interpreter and generate BlockInputStreams.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 10, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented May 10, 2022

Coverage for changed files

Filename                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Coprocessor/DAGQueryBlockInterpreter.cpp         323               108    66.56%          43                 4    90.70%         742               184    75.20%         236               103    56.36%
Coprocessor/DAGQueryBlockInterpreter.h             2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
tests/gtest_interpreter.cpp                       78                38    51.28%           3                 0   100.00%         299                 0   100.00%           8                 8     0.00%
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                            403               146    63.77%          48                 4    91.67%        1043               184    82.36%         244               111    54.51%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18108      9846             45.63%    201651  98500        51.15%

full coverage report (for internal network access only)

@SeaRise SeaRise self-requested a review May 11, 2022 01:59
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2022
SeaRise
SeaRise reviewed May 11, 2022
View reviewed changes
@ywqzzy ywqzzy changed the title Interpreter: Run interpreter test with exchange executor. Interpreter: Run interpreter test with exchange executors May 11, 2022
SeaRise
SeaRise reviewed May 11, 2022
View reviewed changes
@ywqzzy ywqzzy requested review from mengxin9014 and windtalker May 11, 2022 07:56
@ywqzzy ywqzzy force-pushed the run_interpreter_with_exchange branch from fc3f81e to 0f69257 Compare May 11, 2022 08:29
@SeaRise SeaRise self-requested a review May 11, 2022 18:23
SeaRise
SeaRise reviewed May 11, 2022
View reviewed changes
@SeaRise
Copy link
Contributor

SeaRise commented May 11, 2022

other LGTM

@ywqzzy ywqzzy force-pushed the run_interpreter_with_exchange branch from 0e4c4f6 to 9a014d4 Compare May 12, 2022 03:15
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 12, 2022

The latest commit can not pass the test, I pushed it by accident.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2022
Lloyd-Pottiger
Lloyd-Pottiger reviewed May 12, 2022
View reviewed changes
@ywqzzy ywqzzy requested a review from yibin87 May 16, 2022 09:33
yibin87
yibin87 approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
@yibin87
Copy link
Contributor

yibin87 commented May 17, 2022

please help to change the MockTableScanBlockInputStream::makeColumn function, the & operator in for statement, which will cause compilation error for gcc. @ywqzzy

@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 17, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a8ac88b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 17, 2022

Coverage for changed files

Filename                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DataStreams/MockExchangeReceiverInputStream.cpp          13                 9    30.77%           3                 2    33.33%          29                21    27.59%           8                 6    25.00%
DataStreams/MockExchangeReceiverInputStream.h             2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
DataStreams/MockExchangeSenderInputStream.cpp             6                 4    33.33%           4                 2    50.00%          16                10    37.50%           2                 2     0.00%
DataStreams/MockExchangeSenderInputStream.h               1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
DataStreams/MockTableScanBlockInputStream.cpp            13                 0   100.00%           3                 0   100.00%          32                 1    96.88%          10                 1    90.00%
Flash/Coprocessor/DAGQueryBlockInterpreter.cpp          307                94    69.38%          43                 4    90.70%         694               175    74.78%         228                96    57.89%
Flash/Coprocessor/DAGQueryBlockInterpreter.h              2                 0   100.00%           2                 0   100.00%           2                 0   100.00%           0                 0         -
Flash/tests/gtest_interpreter.cpp                        82                38    53.66%           3                 0   100.00%         339                 0   100.00%           8                 8     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   426               145    65.96%          61                 8    86.89%        1115               207    81.43%         256               113    55.86%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18154      9788             46.08%    202633  97914        51.68%

full coverage report (for internal network access only)

@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 17, 2022

/run-integration-test

1 similar comment
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 17, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 6b8ca3d into pingcap:master May 17, 2022
@ywqzzy ywqzzy mentioned this pull request May 17, 2022
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger left review comments

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker Awaiting requested review from windtalker

@mengxin9014 mengxin9014 Awaiting requested review from mengxin9014

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ywqzzy @ti-chi-bot @sre-bot @SeaRise @yibin87 @Lloyd-Pottiger