Skip to content

fix ifnull bug#4832

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
windtalker:ifnull
May 6, 2022
Merged

fix ifnull bug#4832
ti-chi-bot merged 3 commits intopingcap:masterfrom
windtalker:ifnull

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented May 6, 2022 •
edited
Loading

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: close #4829

Problem Summary:

What is changed and how it works?

The root cause is for
ifnull(col1, col2)
TiFlash should rewrite it to
multiIf(isnull(col1), col2, assumeNotNull(col1))
but it rewrite it to
multiIf(isnull(col1), assumeNotNull(col2), col1)

Why unit test does not find this bug:
Because unit test and DAGExpressionAnalyze does not share the same rewrite code, and unit test rewrite it correctly. We should enhance the test framework to ensure the function rewrite logic is the same between unit test and DAGExpressionAnalyze.(#4830)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix ifNull bug if the second argument contains null

@windtalker
fix ifnull bug
02a8250 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-triage-completed labels May 6, 2022
@windtalker windtalker requested review from LittleFall and SeaRise May 6, 2022 03:55
@windtalker
Copy link
Contributor Author

windtalker commented May 6, 2022

/rebuild

SeaRise
SeaRise approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 6, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 6, 2022
@windtalker
Copy link
Contributor Author

windtalker commented May 6, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 02a8250

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 6, 2022

Coverage for changed files

Filename                                                                                                                  Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzerHelper.cpp          86                86     0.00%          12                12     0.00%         223               223     0.00%          64                64     0.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                                          86                86     0.00%          12                12     0.00%         223               223     0.00%          64                64     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18077      10153            43.83%    200526  101010       49.63%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 343e309 into pingcap:master May 6, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 6, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022

In response to a cherrypick label: new pull request created: #4834.

@xzhangxian1008 xzhangxian1008 mentioned this pull request Jun 16, 2022
Closed
@windtalker windtalker deleted the ifnull branch January 30, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@SeaRise SeaRise SeaRise approved these changes

@LittleFall LittleFall LittleFall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The result of where not ifnull() is not correct

5 participants

@windtalker @ti-chi-bot @sre-bot @SeaRise @LittleFall