Skip to content

MPP: update the state of building a hash table when createOnce throw …#4659

Merged
fzhedu merged 1 commit intopingcap:release-5.4-20220312from
fzhedu:cp/4202/cc8a5c5
Apr 14, 2022
Merged

MPP: update the state of building a hash table when createOnce throw …#4659
fzhedu merged 1 commit intopingcap:release-5.4-20220312from
fzhedu:cp/4202/cc8a5c5

Conversation

@fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Apr 14, 2022

…exceptions (#4202)

close #4195

What problem does this PR solve?

cp of PR#4202

Issue Number: close #4195
Problem Summary:
set FinishBuild be true when createOnce throw exceptions

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Apr 14, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

@fzhedu: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fzhedu fzhedu requested a review from windtalker April 14, 2022 07:10
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2022
@fzhedu fzhedu requested a review from zanmato1984 April 14, 2022 07:11
windtalker
windtalker approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2022
@fzhedu fzhedu merged commit eb62cd2 into pingcap:release-5.4-20220312 Apr 14, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
fzhedu
fzhedu commented Jun 16, 2022
View reviewed changes
Copy link
Contributor Author

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees

No one assigned

Labels

do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@fzhedu @ti-chi-bot @windtalker @purelind