Skip to content

Fix crash when prehandle snapshot (#4140)#4656

Merged
lidezhu merged 1 commit intopingcap:release-5.4-20220312from
lidezhu:fix-prehandle-snapshot-5.4-0312
Apr 14, 2022
Merged

Fix crash when prehandle snapshot (#4140)#4656
lidezhu merged 1 commit intopingcap:release-5.4-20220312from
lidezhu:fix-prehandle-snapshot-5.4-0312

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Apr 14, 2022 •
edited
Loading

Cherry pick of #4140

What problem does this PR solve?

Issue Number: ref #4072

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2022

@lidezhu: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2022
@lidezhu lidezhu added the CHERRY-PICK cherry pick label Apr 14, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 14, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 14, 2022

lines: 43.3% (49810 out of 115121)
branches: 6.4% (81421 out of 1263882)

@lidezhu lidezhu merged commit f06e1ee into pingcap:release-5.4-20220312 Apr 14, 2022
@lidezhu lidezhu deleted the fix-prehandle-snapshot-5.4-0312 branch April 14, 2022 08:22
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CHERRY-PICK cherry pick do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v5.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@lidezhu @ti-chi-bot @sre-bot @purelind