Split AstToExecutor from dbgFuncCoprocessor.#4610
Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom Apr 12, 2022
Merged
Split AstToExecutor from dbgFuncCoprocessor.#4610ti-chi-bot merged 11 commits intopingcap:masterfrom
ti-chi-bot merged 11 commits intopingcap:masterfrom
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Member
|
@ywqzzy: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
54 tasks
fuzhe1989
reviewed
Apr 7, 2022
dbms/src/Debug/AstToExecutor.cpp
Outdated
| } | ||
| else if (ASTFunction * func = typeid_cast<ASTFunction *>(ast.get())) | ||
| { | ||
| /// aggregation function is handled in Aggregation, so just treated as a column |
Contributor
There was a problem hiding this comment.
how about move this branch into another function?
Contributor
Author
There was a problem hiding this comment.
how about move this branch into another function?
Good idea. I will refactor them all.
| } | ||
| else if (ASTFunction * func = typeid_cast<ASTFunction *>(ast.get())) | ||
| { | ||
| /// check function |
dbms/src/Debug/AstToExecutor.cpp
Outdated
| } | ||
| } // namespace | ||
|
|
||
| String LOCAL_HOST = "127.0.0.1:3930"; |
Contributor
There was a problem hiding this comment.
move to anonymous namespace?
Contributor
Author
There was a problem hiding this comment.
done. I have moved it into namespace db::debug.
| } | ||
| virtual bool toTiPBExecutor(tipb::Executor * tipb_executor, uint32_t collator_id, const MPPInfo & mpp_info, const Context & context) | ||
| = 0; | ||
| virtual void toMPPSubPlan(size_t & executor_index, const DAGProperties & properties, std::unordered_map<String, std::pair<std::shared_ptr<ExchangeReceiver>, std::shared_ptr<ExchangeSender>>> & exchange_map) |
Contributor
There was a problem hiding this comment.
is executor_index expected to be mutable to derived classes of Executor?
| tipb::ExchangeType type; | ||
| TaskMetas task_metas; | ||
| std::vector<size_t> partition_keys; | ||
| ExchangeSender(size_t & index, const DAGSchema & output, tipb::ExchangeType type_, const std::vector<size_t> & partition_keys_ = {}) |
| struct ExchangeReceiver : Executor | ||
| { | ||
| TaskMetas task_metas; | ||
| ExchangeReceiver(size_t & index, const DAGSchema & output) |
dbms/src/Debug/AstToExecutor.h
Outdated
| { | ||
| TableInfo table_info; | ||
| /// used by column pruner | ||
| TableScan(size_t & index_, const DAGSchema & output_schema_, TableInfo & table_info_) |
Contributor
There was a problem hiding this comment.
ditto, the same as table_info_.
dbms/src/Debug/AstToExecutor.h
Outdated
| struct Selection : public Executor | ||
| { | ||
| std::vector<ASTPtr> conditions; | ||
| Selection(size_t & index_, const DAGSchema & output_schema_, std::vector<ASTPtr> && conditions_) |
Contributor
There was a problem hiding this comment.
Suggested change
| Selection(size_t & index_, const DAGSchema & output_schema_, std::vector<ASTPtr> && conditions_) | |
| Selection(size_t & index_, const DAGSchema & output_schema_, std::vector<ASTPtr> conditions_) |
dbms/src/Debug/AstToExecutor.h
Outdated
| { | ||
| std::vector<ASTPtr> order_columns; | ||
| size_t limit; | ||
| TopN(size_t & index_, const DAGSchema & output_schema_, std::vector<ASTPtr> && order_columns_, size_t limit_) |
Contributor
There was a problem hiding this comment.
Suggested change
| TopN(size_t & index_, const DAGSchema & output_schema_, std::vector<ASTPtr> && order_columns_, size_t limit_) | |
| TopN(size_t & index_, const DAGSchema & output_schema_, std::vector<ASTPtr> order_columns_, size_t limit_) |
fbb50e5 to
0704608
Compare
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-integration-test |
SeaRise
approved these changes
Apr 8, 2022
Contributor
Author
|
/cc @yibin87 |
yibin87
reviewed
Apr 11, 2022
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
fuzhe1989
approved these changes
Apr 11, 2022
windtalker
approved these changes
Apr 12, 2022
dbms/src/Debug/astToExecutor.cpp
Outdated
| {"group_concat", tipb::ExprType::GroupConcat}, | ||
| }); | ||
|
|
||
| DAGColumnInfo toNullableDAGColumnInfo(DAGColumnInfo & input) |
Contributor
There was a problem hiding this comment.
Make the parameter const?
4035bb4 to
f8a5692
Compare
Contributor
Author
|
/merge |
Member
|
@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: f8a5692 |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #4609
Problem Summary:
Need to provide Ast to tipb::Executor helper functions for Interpreter test framework, but all of them are in .cpp file.
What is changed and how it works?
Move Ast to tipb::Executor helper functions to astToExecutor.h
Check List
Tests
Side effects
Documentation
Release note