Skip to content

Interpreter: Remove Truncate query#4587

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
ywqzzy:remove_ast_5
May 11, 2022
Merged

Interpreter: Remove Truncate query#4587
ti-chi-bot merged 4 commits intopingcap:masterfrom
ywqzzy:remove_ast_5

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4860

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 6, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 6, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 6, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp          75                75     0.00%           2                 2     0.00%         111               111     0.00%          50                50     0.00%
Parsers/ParserQuery.cpp                      17                17     0.00%           1                 1     0.00%          21                21     0.00%          18                18     0.00%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        92                92     0.00%           3                 3     0.00%         132               132     0.00%          68                68     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16995      9506             44.07%    191311  96298        49.66%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-linked-issue labels May 11, 2022
@ywqzzy ywqzzy changed the title [DNM] Remove Truncate query. Interpreter: Remove Truncate query May 11, 2022
windtalker
windtalker approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e55b57a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 11, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp          66                66     0.00%           2                 2     0.00%          98                98     0.00%          44                44     0.00%
Parsers/ParserQuery.cpp                      15                 7    53.33%           1                 0   100.00%          19                 0   100.00%          16                15     6.25%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        81                73     9.88%           3                 2    33.33%         117                98    16.24%          60                59     1.67%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18083      9836             45.61%    201541  98191        51.28%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented May 11, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: dcf3fc9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 11, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Functions/FunctionBinaryArithmetic.h         569               203    64.32%          40                 8    80.00%        1193               288    75.86%         274               103    62.41%
Interpreters/InterpreterFactory.cpp           66                66     0.00%           2                 2     0.00%          98                98     0.00%          44                44     0.00%
Parsers/ParserQuery.cpp                       15                 7    53.33%           1                 0   100.00%          19                 0   100.00%          16                15     6.25%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        650               276    57.54%          43                10    76.74%        1310               386    70.53%         334               162    51.50%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18083      9836             45.61%    201541  98196        51.28%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d99b0b7 into pingcap:master May 11, 2022
@ywqzzy ywqzzy mentioned this pull request May 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@SeaRise SeaRise Awaiting requested review from SeaRise

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ywqzzy @ti-chi-bot @sre-bot @windtalker @JaySon-Huang @Lloyd-Pottiger