Skip to content

Interpreter: Remove Table properties query#4586

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
ywqzzy:remove_ast_4
May 12, 2022
Merged

Interpreter: Remove Table properties query#4586
ti-chi-bot merged 3 commits intopingcap:masterfrom
ywqzzy:remove_ast_4

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Apr 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4860

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 6, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Apr 6, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 6, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp           72                72     0.00%           2                 2     0.00%         108               108     0.00%          48                48     0.00%
Parsers/ParserQueryWithOutput.cpp             34                34     0.00%           1                 1     0.00%          45                45     0.00%          30                30     0.00%
Parsers/TablePropertiesQueriesASTs.h          11                11     0.00%           3                 3     0.00%          17                17     0.00%           6                 6     0.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        117               117     0.00%           6                 6     0.00%         170               170     0.00%          84                84     0.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16992      9503             44.07%    191249  96247        49.67%

full coverage report (for internal network access only)

@ywqzzy ywqzzy changed the title [DNM] Remove Table properties query. Interpreter: Remove Table properties query May 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 11, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2022
@ywqzzy ywqzzy requested a review from SeaRise May 12, 2022 03:36
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2022
@SeaRise
Copy link
Contributor

SeaRise commented May 12, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e90a0d3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022

@ywqzzy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented May 12, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/InterpreterFactory.cpp           60                60     0.00%           2                 2     0.00%          90                90     0.00%          40                40     0.00%
Parsers/ParserQueryWithOutput.cpp             30                16    46.67%           1                 0   100.00%          41                14    65.85%          26                22    15.38%
Parsers/TablePropertiesQueriesASTs.h          11                11     0.00%           3                 3     0.00%          17                17     0.00%           6                 6     0.00%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                        101                87    13.86%           6                 5    16.67%         148               121    18.24%          72                68     5.56%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18142      9806             45.95%    202521  98169        51.53%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit ace1369 into pingcap:master May 12, 2022
@ywqzzy ywqzzy mentioned this pull request May 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

+1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ywqzzy @ti-chi-bot @sre-bot @SeaRise @JaySon-Huang