MPP: update the state of building a hash table when createOnce throw exceptions (#4202) by ti-chi-bot · Pull Request #4270 · pingcap/tiflash

ti-chi-bot · 2022-03-14T14:55:09Z

This is an automated cherry-pick of #4202

Signed-off-by: fzhedu fzhedu@gmail.com

What problem does this PR solve?

Issue Number: close #4195
Problem Summary:
set FinishBuild be true when createOnce throw exceptions

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Fix the issue that a query containing `JOIN` could be hung if an error was encountered

Signed-off-by: fzhedu <fzhedu@gmail.com>

ti-chi-bot · 2022-03-14T14:55:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

SeaRise
windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CLAassistant · 2022-04-01T05:59:14Z

All committers have signed the CLA.

CLAassistant · 2022-04-01T06:00:16Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

windtalker

LGTM

fzhedu · 2022-04-25T07:52:51Z

/merge

ti-chi-bot · 2022-04-25T07:52:51Z

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-25T07:52:53Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: e96f5ac

sre-bot · 2022-04-25T08:12:44Z

lines: 43.3% (49956 out of 115330)
branches: 6.5% (81712 out of 1265080)

Signed-off-by: fzhedu <fzhedu@gmail.com>

fzhedu · 2022-04-25T08:48:19Z

/merge

ti-chi-bot · 2022-04-25T08:48:20Z

@fzhedu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-25T08:48:21Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 252ed22

ti-chi-bot · 2022-04-25T08:56:59Z

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-04-25T09:36:05Z

lines: 43.3% (49953 out of 115329)
branches: 6.5% (81709 out of 1265080)

fzhedu added 9 commits March 14, 2022 14:55

set FinishBuild when createOnce throw exceptions

c2ee23b

Signed-off-by: fzhedu <fzhedu@gmail.com>

address comments about set build failed

54952cc

Signed-off-by: fzhedu <fzhedu@gmail.com>

addres comments to throw once build failed

f34a678

Signed-off-by: fzhedu <fzhedu@gmail.com>

update logs

205962f

Signed-off-by: fzhedu <fzhedu@gmail.com>

add failpoint test for hash build

b5c43ca

Signed-off-by: fzhedu <fzhedu@gmail.com>

add failpoint test for hash build

448a2c0

Signed-off-by: fzhedu <fzhedu@gmail.com>

update tests

c1724ba

Signed-off-by: fzhedu <fzhedu@gmail.com>

set BuildTableState

a986286

Signed-off-by: fzhedu <fzhedu@gmail.com>

update log fmt

d62238c

Signed-off-by: fzhedu <fzhedu@gmail.com>

ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2022

ti-chi-bot mentioned this pull request Mar 14, 2022

MPP: update the state of building a hash table when createOnce throw exceptions #4202

Merged

12 tasks

ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Mar 14, 2022

ti-chi-bot assigned fzhedu Mar 14, 2022

VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Apr 10, 2022

VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 21, 2022

JaySon-Huang added this to the v5.4.1 milestone Apr 21, 2022

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 22, 2022

Merge branch 'release-5.4' into cherry-pick-4202-to-release-5.4

e96f5ac

fzhedu requested review from SeaRise and windtalker and removed request for windtalker April 25, 2022 07:46

SeaRise approved these changes Apr 25, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022

windtalker approved these changes Apr 25, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022

fix claing-tidy issues

5c73736

Signed-off-by: fzhedu <fzhedu@gmail.com>

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022

fix claing-tidy issues 2

252ed22

Signed-off-by: fzhedu <fzhedu@gmail.com>

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2022

Merge branch 'release-5.4' into cherry-pick-4202-to-release-5.4

f30cac6

ti-chi-bot merged commit ef69b08 into pingcap:release-5.4 Apr 25, 2022

ti-chi-bot deleted the cherry-pick-4202-to-release-5.4 branch April 15, 2025 07:49

Conversation

ti-chi-bot commented Mar 14, 2022 • edited by JaySon-Huang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Mar 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Apr 1, 2022

Uh oh!

windtalker left a comment

Choose a reason for hiding this comment

Uh oh!

fzhedu commented Apr 25, 2022

Uh oh!

ti-chi-bot commented Apr 25, 2022

Uh oh!

ti-chi-bot commented Apr 25, 2022

Uh oh!

sre-bot commented Apr 25, 2022

Uh oh!

fzhedu commented Apr 25, 2022

Uh oh!

ti-chi-bot commented Apr 25, 2022

Uh oh!

ti-chi-bot commented Apr 25, 2022

Uh oh!

ti-chi-bot commented Apr 25, 2022

Uh oh!

sre-bot commented Apr 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ti-chi-bot commented Mar 14, 2022 •

edited by JaySon-Huang

Loading

ti-chi-bot commented Mar 14, 2022 •

edited

Loading

CLAassistant commented Apr 1, 2022 •

edited

Loading