metrics: support multi-k8s in grafana dashboards (#4099)#4206
Closed
ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
Closed
metrics: support multi-k8s in grafana dashboards (#4099)#4206ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
ti-chi-bot wants to merge 1 commit intopingcap:release-5.4from
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
Author
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
12 tasks
| @@ -4739,7 +4739,11 @@ | |||
| "steppedLine": false, | |||
| "targets": [ | |||
| { | |||
| <<<<<<< HEAD | |||
Comment on lines
+1804
to
+1805
| <<<<<<< HEAD | ||
| ======= |
12 tasks
Contributor
|
Resolve conflict in #4213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4099
Signed-off-by: just1900 legendj228@gmail.com
What problem does this PR solve?
Issue Number: ref #4129
Problem Summary:
K8s community and organizations are increasingly deploying multiple Kubernetes clusters to improve availability, isolation and scalability. Since TiDB Operator have support deploying tidb across-kubernetes, this PR will address the multi-k8s issue without affecting existing single-cluster use case.
What is changed and how it works?
What's Changed:
How it works:
kuberneteslabel to identify k8s cluster in your prometheus'external_labels.sed -i s/"hide": 2/"hide": 0/g <path/to/dashboard.json>Check List
Tests
Side effects
Documentation
Release note