PageStorage: Ref page lifetime mechanism#4174
Merged
ti-chi-bot merged 20 commits intopingcap:masterfrom Mar 8, 2022
Merged
Conversation
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
This was referenced Mar 3, 2022
Closed
07e21aa to
cb4b1ca
Compare
Contributor
Author
|
/run-unit-test |
1 similar comment
Contributor
Author
|
/run-unit-test |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
dd2c101 to
4b68bdc
Compare
Contributor
Author
|
/run-unit-test |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
jiaqizho
reviewed
Mar 7, 2022
jiaqizho
reviewed
Mar 7, 2022
Signed-off-by: JaySon-Huang <tshent@qq.com>
38a19eb to
ce8448f
Compare
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
JaySon-Huang
commented
Mar 7, 2022
Comment on lines
+508
to
+523
| // wal->compactLogs(); | ||
| // wal.reset(); | ||
|
|
||
| // // After logs compacted, they should be written as one edit. | ||
| // num_edits_read = 0; | ||
| // num_pages_read = 0; | ||
| // wal = WALStore::create( | ||
| // [&](PageEntriesEdit && edit) { | ||
| // num_pages_read += edit.size(); | ||
| // EXPECT_EQ(page_id, edit.size()) << fmt::format("at idx={}", num_edits_read); | ||
| // num_edits_read += 1; | ||
| // }, | ||
| // provider, | ||
| // delegator); | ||
| // EXPECT_EQ(num_edits_read, 1); | ||
| // EXPECT_EQ(num_pages_read, page_id); |
Contributor
Author
There was a problem hiding this comment.
These test need to be rewrite in the following PR
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
lidezhu
approved these changes
Mar 7, 2022
Contributor
Author
|
/merge |
Member
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: bf76e3e |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
76 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #4017, ref #3594
Problem Summary:
What is changed and how it works?
Introduce
VarEntryto manage the lifetime of PageEntries/ExternalPages in PageDirectory with RefPage mechanismCheck List
Tests
Side effects
Documentation
Release note