Skip to content

Support user to choose different compression algorithms and compression levels#4161

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
hehechen:compres_config
Mar 2, 2022
Merged

Support user to choose different compression algorithms and compression levels#4161
ti-chi-bot merged 6 commits intopingcap:masterfrom
hehechen:compres_config

Conversation

@hehechen
Copy link
Contributor

@hehechen hehechen commented Feb 28, 2022 •
edited
Loading

What problem does this PR solve?

Support user to choose different compression algorithms and compression levels, including lz4, lz4hc, zstd.

Issue Number: close #3671

What is changed and how it works?

  1. Upgrade zstd library to v1.5.1
  2. The original configurations network_compression_method and network_zstd_compression_level are not used in DeltaTree engine. Modify the name of them to dt_compression_method and dt_compression_level, and apply them to DeltaTree engine.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Add some log in compress and decompress method, modify the configuration values of dt_compression_method and dt_compression_level, check the log to observe whether the compress method and compression level are correct.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support zstd compression

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SchrodingerZhu
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 28, 2022
@SchrodingerZhu SchrodingerZhu changed the title Compres config Compress config Feb 28, 2022
@hehechen
Support user to choose different compression algorithms and compressi…
bbca60c 
…on levels

Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen hehechen changed the title Compress config Support user to choose different compression algorithms and compression levels Feb 28, 2022
@hehechen hehechen requested a review from flowbehappy February 28, 2022 10:29
@hehechen
fix clang tidy
29045dd 
Signed-off-by: hehechen <awd123456sss@gmail.com>
SchrodingerZhu
SchrodingerZhu approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DTTool and DMFile parts LGTM.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 28, 2022
@hehechen
Copy link
Contributor Author

hehechen commented Mar 1, 2022

/run-all-test

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

@hehechen: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 2, 2022

Coverage for changed files

Filename                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
IO/CompressedWriteBuffer.cpp                                    37                 9    75.68%           3                 0   100.00%          85                 8    90.59%          22                 7    68.18%
IO/CompressionSettings.cpp                                       6                 3    50.00%           2                 0   100.00%          17                 6    64.71%           8                 4    50.00%
Interpreters/Context.cpp                                       471               313    33.55%         163                96    41.10%        1048               678    35.31%         240               183    23.75%
Interpreters/Context.h                                          13                 8    38.46%          13                 8    38.46%          13                 8    38.46%           0                 0         -
Interpreters/Settings.h                                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Interpreters/SettingsCommon.h                                  252               200    20.63%         128                90    29.69%         482               386    19.92%          90                82     8.89%
Server/DTTool/DTToolMigrate.cpp                                205                78    61.95%          11                 1    90.91%         282               155    45.04%         124                72    41.94%
Server/tests/gtest_server_config.cpp                          1918               325    83.06%          10                 0   100.00%         395                 3    99.24%         592               293    50.51%
Storages/DeltaMerge/ColumnFile/ColumnFilePersisted.cpp          27                 5    81.48%           8                 0   100.00%          90                11    87.78%          24                 5    79.17%
Storages/DeltaMerge/ColumnFile/ColumnFilePersisted.h             1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp               70                 4    94.29%          14                 0   100.00%         171                 3    98.25%          40                 4    90.00%
Storages/DeltaMerge/File/DMFileBlockOutputStream.h               5                 1    80.00%           5                 1    80.00%           6                 1    83.33%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                         3006               946    68.53%         359               196    45.40%        2591              1259    51.41%        1140               650    42.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16667      9477             43.14%    184395  95776        48.06%

full coverage report (for internal network access only)

flowbehappy
flowbehappy reviewed Mar 2, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Mar 2, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Mar 2, 2022
View reviewed changes
@hehechen
fix comment
edf7c79 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
update config template
1914e47 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
Copy link
Contributor Author

hehechen commented Mar 2, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 2, 2022

Coverage for changed files

Filename                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
IO/CompressedWriteBuffer.cpp                                    37                 9    75.68%           3                 0   100.00%          85                 8    90.59%          22                 7    68.18%
IO/CompressionSettings.cpp                                       7                 4    42.86%           2                 0   100.00%          17                 6    64.71%           8                 4    50.00%
Interpreters/Context.cpp                                       471               313    33.55%         163                96    41.10%        1048               678    35.31%         240               183    23.75%
Interpreters/Context.h                                          13                 8    38.46%          13                 8    38.46%          13                 8    38.46%           0                 0         -
Interpreters/Settings.h                                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Interpreters/SettingsCommon.h                                  252               200    20.63%         128                90    29.69%         482               386    19.92%          90                82     8.89%
Server/DTTool/DTToolMigrate.cpp                                205                78    61.95%          11                 1    90.91%         281               154    45.20%         124                72    41.94%
Server/tests/gtest_server_config.cpp                          1918               325    83.06%          10                 0   100.00%         395                 3    99.24%         592               293    50.51%
Storages/DeltaMerge/ColumnFile/ColumnFilePersisted.cpp          27                 5    81.48%           8                 0   100.00%          90                11    87.78%          24                 5    79.17%
Storages/DeltaMerge/ColumnFile/ColumnFilePersisted.h             1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp               70                 4    94.29%          14                 0   100.00%         171                 3    98.25%          40                 4    90.00%
Storages/DeltaMerge/File/DMFileBlockOutputStream.h               5                 1    80.00%           5                 1    80.00%           6                 1    83.33%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                         3007               947    68.51%         359               196    45.40%        2590              1258    51.43%        1140               650    42.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16667      9478             43.13%    184394  95793        48.05%

full coverage report (for internal network access only)

@hehechen hehechen requested review from flowbehappy and removed request for JaySon-Huang March 2, 2022 09:04
@hehechen hehechen requested a review from JaySon-Huang March 2, 2022 09:04
@flowbehappy
Copy link
Contributor

flowbehappy commented Mar 2, 2022 •
edited
Loading

Please also update the doc here: https://docs.pingcap.com/zh/tidb/stable/tiflash-command-line-flags#dttool-migrate

flowbehappy
flowbehappy approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2022
@hehechen
fix comment
39a5132 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
Copy link
Contributor Author

hehechen commented Mar 2, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 39a5132

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 2, 2022

Coverage for changed files

Filename                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
IO/CompressedWriteBuffer.cpp                                    37                 9    75.68%           3                 0   100.00%          85                 8    90.59%          22                 7    68.18%
IO/CompressionSettings.cpp                                       9                 7    22.22%           2                 1    50.00%          24                17    29.17%          12                 8    33.33%
Interpreters/Context.cpp                                       471               313    33.55%         163                96    41.10%        1048               678    35.31%         240               183    23.75%
Interpreters/Context.h                                          13                 8    38.46%          13                 8    38.46%          13                 8    38.46%           0                 0         -
Interpreters/Settings.h                                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Interpreters/SettingsCommon.h                                  252               200    20.63%         128                90    29.69%         482               386    19.92%          90                82     8.89%
Server/DTTool/DTToolMigrate.cpp                                205                78    61.95%          11                 1    90.91%         281               154    45.20%         124                72    41.94%
Server/tests/gtest_server_config.cpp                          1918               325    83.06%          10                 0   100.00%         395                 3    99.24%         592               293    50.51%
Storages/DeltaMerge/ColumnFile/ColumnFilePersisted.cpp          27                 5    81.48%           8                 0   100.00%          90                11    87.78%          24                 5    79.17%
Storages/DeltaMerge/ColumnFile/ColumnFilePersisted.h             1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp               70                 4    94.29%          14                 0   100.00%         171                 3    98.25%          40                 4    90.00%
Storages/DeltaMerge/File/DMFileBlockOutputStream.h               5                 1    80.00%           5                 1    80.00%           6                 1    83.33%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                         3009               950    68.43%         359               197    45.13%        2597              1269    51.14%        1144               654    42.83%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16689      9455             43.35%    186838  95564        48.85%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d321064 into pingcap:master Mar 2, 2022
@hehechen hehechen deleted the compres_config branch March 2, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

+1 more reviewer

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support compression algorithms with better compression ratios, like zstd

6 participants

@hehechen @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang @SchrodingerZhu