Skip to content

Fix cast datetime to decimal wrong result bug (#4152)#4158

Merged
ti-chi-bot merged 4 commits intopingcap:release-5.2from
ti-chi-bot:cherry-pick-4152-to-release-5.2
Apr 13, 2022
Merged

Fix cast datetime to decimal wrong result bug (#4152)#4158
ti-chi-bot merged 4 commits intopingcap:release-5.2from
ti-chi-bot:cherry-pick-4152-to-release-5.2

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 28, 2022

This is an automated cherry-pick of #4152

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #4151

Problem Summary:

  1. wrong const multipiler
  2. overflow may hanppens

What is changed and how it works?

  1. correct const multipiler
  2. use Int128 instead of UInt64 if fsp > 0

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix cast datetime to decimal wrong result bug

@guo-shaoge @ti-chi-bot
Fix cast datetime to decimal wrong result bug
905a84f 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge @ti-chi-bot
fix
f5fdae6 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Feb 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 28, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.2 labels Feb 28, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 12, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2022
@guo-shaoge
Copy link
Contributor

guo-shaoge commented Apr 13, 2022

/run-all-tests

@guo-shaoge guo-shaoge requested a review from windtalker April 13, 2022 10:58
windtalker
windtalker approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
@guo-shaoge
Copy link
Contributor

guo-shaoge commented Apr 13, 2022

/merge

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 13, 2022

@guo-shaoge: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8915c77

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 13, 2022

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9b95144 into pingcap:release-5.2 Apr 13, 2022
@JaySon-Huang JaySon-Huang added this to the v5.2.4 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees

@guo-shaoge guo-shaoge

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2

Projects

None yet

Milestone

v5.2.4

Development

Successfully merging this pull request may close these issues.

6 participants

@ti-chi-bot @guo-shaoge @windtalker @wshwsh12 @JaySon-Huang @VelocityLight