Skip to content

separate PageIdGenerator from StoragePool#4154

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
lidezhu:seperate-page-id-generator
Mar 1, 2022
Merged

separate PageIdGenerator from StoragePool#4154
ti-chi-bot merged 5 commits intopingcap:masterfrom
lidezhu:seperate-page-id-generator

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Feb 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary: This pr is the preparation work for making the StoragePool able to be a global instance across tiflash. So we separate the per table page id allocation logic to PageIdGenerator.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Feb 28, 2022
@lidezhu lidezhu changed the title seperate PageIdGenerator from StoragePool separate PageIdGenerator from StoragePool Feb 28, 2022
@lidezhu
separate PageIdGenerator from StoragePool
3a7c56a 
Signed-off-by: lidezhu <lidezhu@pingcap.com>
@lidezhu lidezhu force-pushed the seperate-page-id-generator branch from badaa53 to 3a7c56a Compare February 28, 2022 08:59
@lidezhu lidezhu force-pushed the seperate-page-id-generator branch from 0861e29 to a11f9c7 Compare February 28, 2022 09:12
@lidezhu
fix typo
d169075 
Signed-off-by: lidezhu <lidezhu@pingcap.com>
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 28, 2022

/run-all-tests

@lidezhu lidezhu requested a review from JaySon-Huang February 28, 2022 09:40
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 28, 2022

Coverage for changed files

Filename                                                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Server/DTTool/DTToolBench.cpp                                        201               161    19.90%           5                 1    80.00%         329               217    34.04%          82                62    24.39%
Server/tests/gtest_dttool.cpp                                        400                52    87.00%           7                 0   100.00%         218                 6    97.25%         142                61    57.04%
Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp                     70                 4    94.29%          14                 0   100.00%         171                 3    98.25%          40                 4    90.00%
Storages/DeltaMerge/DMContext.h                                        4                 0   100.00%           4                 0   100.00%           7                 0   100.00%           0                 0         -
Storages/DeltaMerge/Delta/ColumnFilePersistedSet.cpp                 243                65    73.25%          19                 0   100.00%         392                56    85.71%         196                58    70.41%
Storages/DeltaMerge/Delta/MemTableSet.cpp                            119                24    79.83%           9                 0   100.00%         194                14    92.78%          96                25    73.96%
Storages/DeltaMerge/DeltaMergeStore.cpp                             1278               435    65.96%          65                 5    92.31%        1859               413    77.78%         746               351    52.95%
Storages/DeltaMerge/DeltaMergeStore.h                                 41                13    68.29%          19                 2    89.47%          85                30    64.71%          42                11    73.81%
Storages/DeltaMerge/Segment.cpp                                      637               189    70.33%          45                 4    91.11%        1121               266    76.27%         332               176    46.99%
Storages/DeltaMerge/StoragePool.cpp                                   37                 1    97.30%           7                 0   100.00%          87                 4    95.40%          20                 4    80.00%
Storages/DeltaMerge/StoragePool.h                                     10                 2    80.00%          10                 2    80.00%          10                 2    80.00%           0                 0         -
Storages/DeltaMerge/tests/gtest_dm_delta_value_space.cpp            1436               209    85.45%          17                 1    94.12%         509                 7    98.62%         444               208    53.15%
Storages/DeltaMerge/tests/gtest_dm_file.cpp                         3253              1071    67.08%          38                 0   100.00%        1482                 2    99.87%         958               418    56.37%
Storages/DeltaMerge/tests/gtest_dm_segment.cpp                      3343               840    74.87%          37                 1    97.30%        1472                40    97.28%        1112               473    57.46%
Storages/DeltaMerge/tests/gtest_dm_segment_common_handle.cpp        1258               347    72.42%          17                 0   100.00%         816                23    97.18%         428               182    57.48%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                              12330              3413    72.32%         313                16    94.89%        8752              1083    87.63%        4638              2033    56.17%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16717      9483             43.27%    186704  95643        48.77%

full coverage report (for internal network access only)

JaySon-Huang
JaySon-Huang reviewed Feb 28, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Feb 28, 2022
View reviewed changes
@lidezhu
remove unused function and fix log
9b9206c 
Signed-off-by: lidezhu <lidezhu@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 1, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 1, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2f7d664

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 1, 2022

/run-unit-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 1, 2022

Coverage for changed files

Filename                                                         Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Server/DTTool/DTToolBench.cpp                                        201               161    19.90%           5                 1    80.00%         329               217    34.04%          82                62    24.39%
Server/tests/gtest_dttool.cpp                                        400                52    87.00%           7                 0   100.00%         218                 6    97.25%         142                61    57.04%
Storages/DeltaMerge/ColumnFile/ColumnFileTiny.cpp                     70                 4    94.29%          14                 0   100.00%         171                 3    98.25%          40                 4    90.00%
Storages/DeltaMerge/DMContext.h                                        4                 0   100.00%           4                 0   100.00%           7                 0   100.00%           0                 0         -
Storages/DeltaMerge/Delta/ColumnFilePersistedSet.cpp                 243                65    73.25%          19                 0   100.00%         392                56    85.71%         196                58    70.41%
Storages/DeltaMerge/Delta/MemTableSet.cpp                            119                24    79.83%           9                 0   100.00%         194                14    92.78%          96                25    73.96%
Storages/DeltaMerge/DeltaMergeStore.cpp                             1278               435    65.96%          65                 5    92.31%        1859               413    77.78%         746               351    52.95%
Storages/DeltaMerge/DeltaMergeStore.h                                 41                13    68.29%          19                 2    89.47%          85                30    64.71%          42                11    73.81%
Storages/DeltaMerge/Segment.cpp                                      637               189    70.33%          45                 4    91.11%        1121               266    76.27%         332               176    46.99%
Storages/DeltaMerge/StoragePool.cpp                                   41                 2    95.12%           7                 0   100.00%          89                 4    95.51%          20                 4    80.00%
Storages/DeltaMerge/StoragePool.h                                      8                 0   100.00%           8                 0   100.00%           8                 0   100.00%           0                 0         -
Storages/DeltaMerge/tests/gtest_dm_delta_value_space.cpp            1436               209    85.45%          17                 1    94.12%         509                 7    98.62%         444               208    53.15%
Storages/DeltaMerge/tests/gtest_dm_file.cpp                         3253              1071    67.08%          38                 0   100.00%        1482                 2    99.87%         958               418    56.37%
Storages/DeltaMerge/tests/gtest_dm_segment.cpp                      3343               840    74.87%          37                 1    97.30%        1472                40    97.28%        1112               473    57.46%
Storages/DeltaMerge/tests/gtest_dm_segment_common_handle.cpp        1258               347    72.42%          17                 0   100.00%         816                23    97.18%         428               182    57.48%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                              12332              3412    72.33%         311                14    95.50%        8752              1081    87.65%        4638              2033    56.17%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16715      9481             43.28%    186704  95657        48.77%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 4954a24 into pingcap:master Mar 1, 2022
@lidezhu lidezhu deleted the seperate-page-id-generator branch March 1, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang