async server#4120
Merged
ti-chi-bot merged 166 commits intopingcap:masterfrom Mar 13, 2022
bestwoody:async_server_base
Merged
Conversation
Contributor
Author
|
/rebuild |
1 similar comment
Contributor
Author
|
/rebuild |
Contributor
Author
|
/rebuild |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Signed-off-by: bestwoody <bestwoody@163.com>
Member
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
Contributor
Author
|
/run-all-tests |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/merge |
Member
|
@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 57580bf |
Collaborator
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
Contributor
Author
|
/merge |
Member
|
@bestwoody: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
fzhedu
reviewed
Mar 18, 2022
| flash_service = std::make_unique<AsyncFlashService>(server); | ||
| else | ||
| flash_service = std::make_unique<FlashService>(server); | ||
| diagnostics_service = std::make_unique<DiagnosticsService>(server); |
Contributor
There was a problem hiding this comment.
are these args reasonalbe for async server?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
https://pingcap.feishu.cn/docs/doccnjURwS2PfTpz0tDolmUtsAe
Concept:
CallData: grpc session container with context data for that session. A state machine to react for the gRPC event(such as: write, writeDone, return Status ...)
Tag: a unique instance of CallData
CQ is the queue for polling the gRPC events.
How to develop a async server:
Use WithAsyncMethod_AAA template class to implement a async service.
For the api AAA you want it to be async, implement CallData for it.
Check List
Tests
Side effects
Documentation
Release note