Skip to content

Add benchmark for cast(int/decimal as decimal)#4066

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
guo-shaoge:bench_cast
Feb 18, 2022
Merged

Add benchmark for cast(int/decimal as decimal)#4066
ti-chi-bot merged 1 commit intopingcap:masterfrom
guo-shaoge:bench_cast

Conversation

@guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Feb 17, 2022

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@guo-shaoge
Add benchmark for cast(int/decimal as decimal)
cdfbcc6 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2022
@guo-shaoge
Copy link
Contributor Author

guo-shaoge commented Feb 17, 2022

/run-all-tests

@guo-shaoge guo-shaoge requested a review from fuzhe1989 February 17, 2022 14:51
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 17, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 17, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionTestUtils.cpp              56                 8    85.71%           8                 0   100.00%          69                 8    88.41%          24                 8    66.67%
FunctionTestUtils.h                99                 9    90.91%          32                 0   100.00%         239                 5    97.91%          36                 4    88.89%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             155                17    89.03%          40                 0   100.00%         308                13    95.78%          60                12    80.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16546      9502             42.57%    182840  96099        47.44%

full coverage report (for internal network access only)

windtalker
windtalker approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windtalker
Copy link
Contributor

windtalker commented Feb 18, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2022

@windtalker: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 18, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: cdfbcc6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 18, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FunctionTestUtils.cpp              56                 8    85.71%           8                 0   100.00%          69                 8    88.41%          24                 8    66.67%
FunctionTestUtils.h                99                 9    90.91%          32                 0   100.00%         239                 5    97.91%          36                 4    88.89%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             155                17    89.03%          40                 0   100.00%         308                13    95.78%          60                12    80.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16546      9501             42.58%    182840  96088        47.45%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5f8d3c3 into pingcap:master Feb 18, 2022
@guo-shaoge guo-shaoge mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guo-shaoge @ti-chi-bot @sre-bot @windtalker @fuzhe1989