Skip to content

PageStorage: Restore stats for BlobStore #3986

Merged
ti-chi-bot merged 8 commits intopingcap:masterfrom
JaySon-Huang:add-blobstore-restore
Feb 10, 2022
Merged

PageStorage: Restore stats for BlobStore #3986
ti-chi-bot merged 8 commits intopingcap:masterfrom
JaySon-Huang:add-blobstore-restore

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Feb 9, 2022

What problem does this PR solve?

Issue Number: a part of #3594

Problem Summary: Restore stats, roll_id, old_ids for BlobStore

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

jiaqizho and others added 8 commits February 9, 2022 21:54
@jiaqizho @JaySon-Huang
Add BlobStore restore
a84e72e
@JaySon-Huang
Add TODO
43b1604
@JaySon-Huang
Fix lints
fac0a28 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Add test for restoring the roll_id
a26d23c 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Update comments
3f65ae2 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Restore old_ids
51b5d72 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Rename func name
a3148ad 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Add test for restoring BlobStore
0b6015b 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 9, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 9, 2022
@JaySon-Huang JaySon-Huang requested a review from jiaqizho February 9, 2022 17:47
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 9, 2022
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 9, 2022

/run-all-tests

@JaySon-Huang JaySon-Huang mentioned this pull request Feb 9, 2022
Closed
76 tasks
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 9, 2022

Coverage for changed files

Filename                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                       322               107    66.77%          39                 6    84.62%         720               207    71.25%         200                77    61.50%
BlobStore.h                           7                 2    71.43%           7                 2    71.43%          25                11    56.00%           0                 0         -
PageStorageImpl.cpp                  70                27    61.43%          18                 9    50.00%         164                75    54.27%          40                24    40.00%
spacemap/SpaceMap.cpp                27                 4    85.19%           7                 0   100.00%          54                15    72.22%          20                 6    70.00%
spacemap/SpaceMap.h                   7                 2    71.43%           4                 1    75.00%          18                 5    72.22%           6                 1    83.33%
spacemap/SpaceMapRBTree.cpp         326                78    76.07%          17                 1    94.12%         529               104    80.34%         192                61    68.23%
spacemap/SpaceMapRBTree.h             2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
spacemap/SpaceMapSTDMap.h           135                12    91.11%          10                 0   100.00%         217                25    88.48%          84                19    77.38%
tests/gtest_blob_store.cpp         3479               559    83.93%          16                 0   100.00%         694                 0   100.00%        1080               508    52.96%
tests/gtest_free_map.cpp           1754               294    83.24%          11                 0   100.00%         228                 0   100.00%         586               293    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              6129              1085    82.30%         131                19    85.50%        2654               442    83.35%        2208               989    55.21%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16367      9720             40.61%    179504  98567        45.09%

full coverage report (for internal network access only)

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 10, 2022

@jiaqizho PTAL

@JaySon-Huang JaySon-Huang self-assigned this Feb 10, 2022
@jiaqizho jiaqizho mentioned this pull request Feb 10, 2022
Closed
12 tasks
jiaqizho
jiaqizho approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 10, 2022
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Feb 10, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 0b6015b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 10, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 10, 2022

Coverage for changed files

Filename                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                       322               107    66.77%          39                 6    84.62%         720               207    71.25%         200                77    61.50%
BlobStore.h                           7                 2    71.43%           7                 2    71.43%          25                11    56.00%           0                 0         -
PageStorageImpl.cpp                  70                27    61.43%          18                 9    50.00%         164                75    54.27%          40                24    40.00%
spacemap/SpaceMap.cpp                27                 4    85.19%           7                 0   100.00%          54                15    72.22%          20                 6    70.00%
spacemap/SpaceMap.h                   7                 2    71.43%           4                 1    75.00%          18                 5    72.22%           6                 1    83.33%
spacemap/SpaceMapRBTree.cpp         326                78    76.07%          17                 1    94.12%         529               104    80.34%         192                61    68.23%
spacemap/SpaceMapRBTree.h             2                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
spacemap/SpaceMapSTDMap.h           135                12    91.11%          10                 0   100.00%         217                25    88.48%          84                19    77.38%
tests/gtest_blob_store.cpp         3479               559    83.93%          16                 0   100.00%         694                 0   100.00%        1080               508    52.96%
tests/gtest_free_map.cpp           1754               294    83.24%          11                 0   100.00%         228                 0   100.00%         586               293    50.00%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                              6129              1085    82.30%         131                19    85.50%        2654               442    83.35%        2208               989    55.21%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16367      9720             40.61%    179504  98563        45.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit cc30d07 into pingcap:master Feb 10, 2022
@JaySon-Huang JaySon-Huang deleted the add-blobstore-restore branch February 10, 2022 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jiaqizho jiaqizho jiaqizho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JaySon-Huang JaySon-Huang

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JaySon-Huang @ti-chi-bot @sre-bot @jiaqizho