Skip to content

Fix memory wasted in BlobStore::read#3953

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
jiaqizho:fix-blobstore-read
Jan 27, 2022
Merged

Fix memory wasted in BlobStore::read#3953
ti-chi-bot merged 5 commits intopingcap:masterfrom
jiaqizho:fix-blobstore-read

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Jan 27, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

also enable V3 restore.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 27, 2022
@jiaqizho jiaqizho requested a review from JaySon-Huang January 27, 2022 06:53
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 27, 2022
JaySon-Huang
JaySon-Huang approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2022
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Jan 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: dcc99f4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 27, 2022

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Storages/Page/V3/BlobStore.cpp         305               110    63.93%          34                 6    82.35%         669               220    67.12%         188                82    56.38%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                       305               110    63.93%          34                 6    82.35%         669               220    67.12%         188                82    56.38%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16263      9693             40.40%    177916  98264        44.77%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jan 27, 2022

Coverage for changed files

Filename                                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/build/tics/dbms/src/Storages/Page/V3/BlobStore.cpp         305               110    63.93%          34                 6    82.35%         669               220    67.12%         188                82    56.38%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                       305               110    63.93%          34                 6    82.35%         669               220    67.12%         188                82    56.38%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16263      9694             40.39%    177916  98272        44.76%

full coverage report (for internal network access only)

@JaySon-Huang
Fix lint
d5fc26b 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jan 27, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d5fc26b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@JaySon-Huang JaySon-Huang mentioned this pull request Jan 27, 2022
Closed
76 tasks
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 27, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                     305               110    63.93%          34                 6    82.35%         669               220    67.12%         188                82    56.38%
BlobStore.h                         6                 2    66.67%           6                 2    66.67%          24                11    54.17%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             311               112    63.99%          40                 8    80.00%         693               231    66.67%         188                82    56.38%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16263      9694             40.39%    177916  98269        44.77%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e4d1628 into pingcap:master Jan 27, 2022
@JaySon-Huang JaySon-Huang deleted the fix-blobstore-read branch January 27, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiaqizho @ti-chi-bot @sre-bot @JaySon-Huang