Skip to content

Separate storage delta layer to multiple layers#3943

Merged
ti-chi-bot merged 37 commits intopingcap:masterfrom
lidezhu:refactor-delta-tree2
Feb 22, 2022
Merged

Separate storage delta layer to multiple layers#3943
ti-chi-bot merged 37 commits intopingcap:masterfrom
lidezhu:refactor-delta-tree2

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Jan 26, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4089

Problem Summary: second part of #3865.

What is changed and how it works?

Detailed change: https://docs.google.com/document/d/1nlUaeNHdGIIeAVP_XBOWdEcS0P6h9azoYATFQ98XONs/edit

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
    image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 26, 2022
@lidezhu lidezhu force-pushed the refactor-delta-tree2 branch from 35f4547 to e5197af Compare February 7, 2022 10:48
@lidezhu lidezhu force-pushed the refactor-delta-tree2 branch from 1cd5738 to aca8b97 Compare February 7, 2022 14:42
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2022
@lidezhu lidezhu force-pushed the refactor-delta-tree2 branch from 73f7aa1 to 807ab83 Compare February 10, 2022 05:38
flowbehappy
flowbehappy reviewed Feb 16, 2022
View reviewed changes
flowbehappy
flowbehappy reviewed Feb 16, 2022
View reviewed changes
flowbehappy
flowbehappy reviewed Feb 16, 2022
View reviewed changes
@flowbehappy flowbehappy self-requested a review February 21, 2022 04:23
flowbehappy
flowbehappy approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 21, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Feb 22, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 22, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2850b36

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Feb 22, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16674      9491             43.08%    184376  95839        48.02%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit fb00fbb into pingcap:master Feb 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 17, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16674      9491             43.08%    184376  95859        48.01%

full coverage report (for internal network access only)

@JaySon-Huang JaySon-Huang deleted the refactor-delta-tree2 branch March 17, 2022 04:39
This was referenced Mar 23, 2022
Merged
Merged
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 23, 2022
Merged
12 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request Aug 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@flowbehappy flowbehappy flowbehappy approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor DeltaTree storage to two layers

5 participants

@lidezhu @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang