Skip to content

Add interface into mvcc and blobstore#3908

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
jiaqizho:add-interface-in-mvcc-blobstore
Jan 26, 2022
Merged

Add interface into mvcc and blobstore#3908
ti-chi-bot merged 6 commits intopingcap:masterfrom
jiaqizho:add-interface-in-mvcc-blobstore

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Jan 20, 2022

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@jiaqizho jiaqizho requested a review from JaySon-Huang January 20, 2022 06:23
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2022
@jiaqizho jiaqizho mentioned this pull request Jan 20, 2022
Closed
12 tasks
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 21, 2022
JaySon-Huang
JaySon-Huang reviewed Jan 21, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Jan 21, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 24, 2022
@jiaqizho jiaqizho mentioned this pull request Jan 24, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 25, 2022
JaySon-Huang
JaySon-Huang reviewed Jan 25, 2022
View reviewed changes
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jan 25, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jan 25, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1157/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51644 out of 115510)
branches: 7.1% (89939 out of 1275287)

JaySon-Huang
JaySon-Huang reviewed Jan 25, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Jan 25, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Jan 25, 2022
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Jan 25, 2022
View reviewed changes
dbms/src/Storages/Page/V3/PageDirectory.h Outdated
Comment on lines +167 to +168
using ConcreteSnapshotRawPtr = PageDirectorySnapshot *;

Copy link
Contributor

@JaySon-Huang JaySon-Huang Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we don't need it?

JaySon-Huang
JaySon-Huang approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022
@JaySon-Huang JaySon-Huang mentioned this pull request Jan 26, 2022
Closed
76 tasks
JaySon-Huang
JaySon-Huang reviewed Jan 26, 2022
View reviewed changes
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jan 26, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 4cc9ff0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 26, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1179/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51657 out of 115527)
branches: 7.1% (89946 out of 1275321)

@ti-chi-bot ti-chi-bot merged commit df48044 into pingcap:master Jan 26, 2022
@jiaqizho jiaqizho mentioned this pull request Jan 26, 2022
Merged
12 tasks
@JaySon-Huang JaySon-Huang deleted the add-interface-in-mvcc-blobstore branch January 26, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiaqizho @ti-chi-bot @JaySon-Huang @sre-bot