[REVIEW NOTIFICATION]

This pull request has been approved by:

• JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

@JaySon-Huang PTAL

Can we simplify BlobStore::BlobStats::eraseStat to eliminate the variable found?

void BlobStore::BlobStats::eraseStat(const BlobFileId blob_file_id, const std::lock_guard<std::mutex> & lock)
{
    BlobStatPtr stat = nullptr;

    for (auto & stat_in_map : stats_map)
    {
        if (stat->id == blob_file_id)
        {
            stat = stat_in_map;
            break;
        }
    }

    if (stat != nullptr)
    {
        LOG_FMT_ERROR(log, "No exist BlobStat [BlobFileId={}]", blob_file_id);
        return;
    }

    LOG_FMT_DEBUG(log, "Erase BlobStat from maps [BlobFileId={}]", blob_file_id);

    eraseStat(std::move(stat), lock);
}

Can we simplify BlobStore::BlobStats::eraseStat to eliminate the variable found?

void BlobStore::BlobStats::eraseStat(const BlobFileId blob_file_id, const std::lock_guard<std::mutex> & lock)
{
    BlobStatPtr stat = nullptr;

    for (auto & stat_in_map : stats_map)
    {
        if (stat->id == blob_file_id)
        {
            stat = stat_in_map;
            break;
        }
    }

    if (stat != nullptr)
    {
        LOG_FMT_ERROR(log, "No exist BlobStat [BlobFileId={}]", blob_file_id);
        return;
    }

    LOG_FMT_DEBUG(log, "Erase BlobStat from maps [BlobFileId={}]", blob_file_id);

    eraseStat(std::move(stat), lock);
}

changed.

/run-all-tests

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1130/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51591 out of 115297)
branches: 7.0% (89898 out of 1275491)

/merge

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

This pull request has been accepted and is ready to merge.

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1134/cobertura/
(Coverage detail url is limited office network access)

lines: 44.8% (51637 out of 115387)
branches: 7.1% (89938 out of 1275203)