Skip to content

PageStorage: Fix locks on BlobStore, PageDirectory#3897

Closed
JaySon-Huang wants to merge 3 commits intopingcap:masterfrom
JaySon-Huang:fix_blob_lock
Closed

PageStorage: Fix locks on BlobStore, PageDirectory#3897
JaySon-Huang wants to merge 3 commits intopingcap:masterfrom
JaySon-Huang:fix_blob_lock

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jan 19, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: a part of #3594; review on the locks problem brought by #3637 #3701

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@JaySon-Huang
Fix lock on blob store
eae7b90 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Fix lock on PageDirectory
ca65a7b 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 19, 2022

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2022
@JaySon-Huang JaySon-Huang requested a review from jiaqizho January 19, 2022 12:10
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jan 19, 2022

/run-all-tests

@JaySon-Huang JaySon-Huang mentioned this pull request Jan 19, 2022
Merged
12 tasks
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 19, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1066/cobertura/
(Coverage detail url is limited office network access)

lines: 44.7% (51508 out of 115176)
branches: 7.0% (89822 out of 1275263)

@JaySon-Huang JaySon-Huang mentioned this pull request Jan 19, 2022
Closed
12 tasks
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2022
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Jan 20, 2022

Done in #3879

@JaySon-Huang JaySon-Huang deleted the fix_blob_lock branch January 20, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiaqizho jiaqizho Awaiting requested review from jiaqizho

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaySon-Huang @ti-chi-bot @sre-bot