PageStorage: WALStore by JaySon-Huang · Pull Request #3891 · pingcap/tiflash

JaySon-Huang · 2022-01-19T05:50:41Z

What problem does this PR solve?

Issue Number: a part of #3594, WALStore implementation

What is changed and how it works?

Add InMemoryPageDirectory that only stores the latest version of entry for restoring and compact logs in WALStore
Serializing/Deserializing PageEntriesEdit as WAL record
Implement compact logs to make the restore time more reasonable

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-01-19T05:50:43Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

JaySon-Huang · 2022-01-19T05:51:15Z

Need to add more tests currently.

dbms/src/Storages/Page/V3/PageDirectory.cpp

JaySon-Huang · 2022-01-21T12:52:32Z

/run-all-tests

JaySon-Huang · 2022-01-21T13:58:27Z

/run-all-tests

JaySon-Huang · 2022-01-21T14:49:08Z

/run-unit-test

JaySon-Huang · 2022-01-24T02:56:52Z

/run-unit-test

JaySon-Huang · 2022-01-24T05:03:56Z

/run-unit-test

JaySon-Huang · 2022-01-24T07:47:45Z

/run-unit-test

JaySon-Huang · 2022-01-24T10:09:45Z

/run-all-tests

JaySon-Huang · 2022-01-25T02:29:31Z

/run-all-tests

JaySon-Huang · 2022-01-25T02:41:40Z

@jiaqizho PTAL

sre-bot · 2022-01-25T02:44:01Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1156/cobertura/
(Coverage detail url is limited office network access)

lines: 45.1% (52356 out of 116141)
branches: 7.1% (90625 out of 1277280)

dbms/src/Storages/Page/V3/LogFile/LogFilename.h

jiaqizho · 2022-01-25T07:15:04Z

dbms/src/Storages/Page/V3/WAL/WALReader.cpp

we not support multi-path yet. how about just used delegator->defaultPath replace L22-34.

I prefer to keep it since we need to write the same code later. Just keep the assertion for TODO.

dbms/src/Storages/Page/V3/WAL/WALReader.cpp

dbms/src/Storages/Page/V3/WAL/serialize.cpp

dbms/src/Storages/Page/V3/WALStore.cpp

jiaqizho

So I think the logical in PageDirectory restore, should put into PageStorageImpl?

cause we also need BlobStore restore, eq. restore the BlobStats and rebuild the inside spacemap.

dbms/src/Storages/Page/V3/WALStore.cpp

jiaqizho · 2022-01-25T07:44:35Z

dbms/src/Storages/Page/V3/WALStore.cpp

how about changing the LogFilenameSet to list and pop_back?

I use the sorted set to keep the order of restoring log files

The LogFilename only store some string and don't contains any fd, so I think releasing them by list::pop_back is not very necessary

I'm not sure whether we still need this ordering after we

persisted REF as PUT

use CollapsingPageDirectory to restore data and only keep the largest version of entry

maybe come back to it later?

dbms/src/Storages/Page/V3/WALStore.cpp

JaySon-Huang · 2022-01-25T08:57:29Z

/run-unit-test

sre-bot · 2022-01-25T09:11:30Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1174/cobertura/
(Coverage detail url is limited office network access)

lines: 45.1% (52381 out of 116163)
branches: 7.1% (90639 out of 1277294)

JaySon-Huang · 2022-01-25T10:11:54Z

/run-all-tests

Signed-off-by: JaySon-Huang <tshent@qq.com>

JaySon-Huang · 2022-01-26T04:16:56Z

/merge

ti-chi-bot · 2022-01-26T04:16:57Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-01-26T04:17:05Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: d8ff1f8

JaySon-Huang · 2022-01-26T04:18:22Z

/merge

ti-chi-bot · 2022-01-26T04:18:23Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2022-01-26T04:38:37Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1194/cobertura/
(Coverage detail url is limited office network access)

lines: 45.1% (52458 out of 116360)
branches: 7.1% (90768 out of 1277726)

sre-bot · 2022-01-26T04:47:46Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/1198/cobertura/
(Coverage detail url is limited office network access)

lines: 45.1% (52452 out of 116380)
branches: 7.1% (90753 out of 1277738)

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2022

JaySon-Huang mentioned this pull request Jan 19, 2022

Refine the GC interface by PageEntriesEdit #3879

Merged

12 tasks

JaySon-Huang commented Jan 19, 2022

View reviewed changes

dbms/src/Storages/Page/V3/PageDirectory.cpp Outdated Show resolved Hide resolved

JaySon-Huang force-pushed the ps_walstore branch 4 times, most recently from 42b2481 to ce91533 Compare January 21, 2022 11:28

JaySon-Huang force-pushed the ps_walstore branch from 58eb213 to 3935346 Compare January 24, 2022 09:53

JaySon-Huang force-pushed the ps_walstore branch 2 times, most recently from d18c73c to 26978e8 Compare January 25, 2022 02:08

jiaqizho self-requested a review January 25, 2022 02:46

jiaqizho reviewed Jan 25, 2022

View reviewed changes

JaySon-Huang mentioned this pull request Jan 25, 2022

Introduce PageStorage V3 to reduce CPU usage and write amplification #3594

Closed

76 tasks

JaySon-Huang added 16 commits January 26, 2022 11:46

Add InMemoryPageDirectory for restoring and compact logs

8ed7844

Signed-off-by: JaySon-Huang <tshent@qq.com>

Fix naming

3d4d282

Signed-off-by: JaySon-Huang <tshent@qq.com>

Remove useless method from log reader

5ef2b2d

Signed-off-by: JaySon-Huang <tshent@qq.com>

Set the max persisted sequence after restored from disk

82e89c8

Signed-off-by: JaySon-Huang <tshent@qq.com>

Add compact logs

30362f9

Signed-off-by: JaySon-Huang <tshent@qq.com>

Add test for logfilename

dbbef4a

Signed-off-by: JaySon-Huang <tshent@qq.com>

Fix compile error

a5840ec

Signed-off-by: JaySon-Huang <tshent@qq.com>

Small fix

b223fa4

Signed-off-by: JaySon-Huang <tshent@qq.com>

Rename to CollapsingPageDirectory

5f129df

Signed-off-by: JaySon-Huang <tshent@qq.com>

Add comments

444aaac

Signed-off-by: JaySon-Huang <tshent@qq.com>

Create PageDirectory by static method

1b5c391

Signed-off-by: JaySon-Huang <tshent@qq.com>

Address comment

7668838

Signed-off-by: JaySon-Huang <tshent@qq.com>

Throw exception for error in log files

44962fa

Signed-off-by: JaySon-Huang <tshent@qq.com>

Close the fd explicitly in ~LogWriter

aacbbbe

Signed-off-by: JaySon-Huang <tshent@qq.com>

Protect WALStore::log_file by mutex

4cf0b45

Signed-off-by: JaySon-Huang <tshent@qq.com>

Optimize lock on PageDirectory::gcApply

d8ff1f8

Signed-off-by: JaySon-Huang <tshent@qq.com>

JaySon-Huang force-pushed the ps_walstore branch from 1576775 to d8ff1f8 Compare January 26, 2022 03:48

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022

Merge branch 'master' into ps_walstore

9239109

Merge branch 'master' into ps_walstore

18e6c98

ti-chi-bot merged commit cc71835 into pingcap:master Jan 26, 2022

JaySon-Huang deleted the ps_walstore branch January 26, 2022 04:58

Conversation

JaySon-Huang commented Jan 19, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

Uh oh!

ti-chi-bot commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaySon-Huang commented Jan 19, 2022

Uh oh!

Uh oh!

JaySon-Huang commented Jan 21, 2022

Uh oh!

JaySon-Huang commented Jan 21, 2022

Uh oh!

JaySon-Huang commented Jan 21, 2022

Uh oh!

JaySon-Huang commented Jan 24, 2022

Uh oh!

JaySon-Huang commented Jan 24, 2022

Uh oh!

JaySon-Huang commented Jan 24, 2022

Uh oh!

JaySon-Huang commented Jan 24, 2022

Uh oh!

JaySon-Huang commented Jan 25, 2022

Uh oh!

JaySon-Huang commented Jan 25, 2022

Uh oh!

sre-bot commented Jan 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jiaqizho Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jiaqizho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jiaqizho Jan 25, 2022

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang Jan 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JaySon-Huang commented Jan 25, 2022

Uh oh!

sre-bot commented Jan 25, 2022

Uh oh!

JaySon-Huang commented Jan 25, 2022

Uh oh!

JaySon-Huang commented Jan 26, 2022

Uh oh!

ti-chi-bot commented Jan 26, 2022

Uh oh!

ti-chi-bot commented Jan 26, 2022

Uh oh!

JaySon-Huang commented Jan 26, 2022

Uh oh!

ti-chi-bot commented Jan 26, 2022

Uh oh!

sre-bot commented Jan 26, 2022

Uh oh!

sre-bot commented Jan 26, 2022

Uh oh!

Reviewers

ti-chi-bot commented Jan 19, 2022 •

edited

Loading

JaySon-Huang Jan 25, 2022 •

edited

Loading

JaySon-Huang Jan 25, 2022 •

edited

Loading