Skip to content

Fix the exception caused when put and ref are in the same WriteBatch#3829

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
jiaqizho:fix-mvcc-ex
Jan 10, 2022
Merged

Fix the exception caused when put and ref are in the same WriteBatch#3829
ti-chi-bot merged 4 commits intopingcap:masterfrom
jiaqizho:fix-mvcc-ex

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Jan 7, 2022 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: related to #3594, introduced by #3637

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@jiaqizho jiaqizho requested a review from JaySon-Huang January 7, 2022 05:55
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2022
@JaySon-Huang JaySon-Huang changed the title Fix the exception caused when and are in the same WriteBatch Fix the exception caused when put and ref are in the same WriteBatch Jan 7, 2022
JaySon-Huang
JaySon-Huang approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comments

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 7, 2022
@JaySon-Huang JaySon-Huang mentioned this pull request Jan 7, 2022
Closed
76 tasks
JaySon-Huang
JaySon-Huang reviewed Jan 7, 2022
View reviewed changes
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Jan 10, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 6349958

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jan 10, 2022

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/902/cobertura/
(Coverage detail url is limited office network access)

lines: 43.7% (49838 out of 113993)
branches: 6.4% (81056 out of 1261495)

@ti-chi-bot ti-chi-bot merged commit 873d8f6 into pingcap:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiaqizho @ti-chi-bot @sre-bot @JaySon-Huang