Skip to content

Fix PageDirectory dead-lock when writebatch contains two identical pageid.#3750

Merged
ti-chi-bot merged 9 commits intopingcap:masterfrom
jiaqizho:mvcc-dead-lock
Dec 28, 2021
Merged

Fix PageDirectory dead-lock when writebatch contains two identical pageid.#3750
ti-chi-bot merged 9 commits intopingcap:masterfrom
jiaqizho:mvcc-dead-lock

Conversation

@jiaqizho
Copy link
Contributor

…geid

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 28, 2021
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f2ff623

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 28, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/659/cobertura/
(Coverage detail url is limited office network access)

lines: 42.7% (48200 out of 112756)
branches: 6.1% (74605 out of 1213204)

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 28, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/662/cobertura/
(Coverage detail url is limited office network access)

lines: 42.9% (48452 out of 112850)
branches: 6.2% (75637 out of 1215137)

@ti-chi-bot
Copy link
Member

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 28, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/668/cobertura/
(Coverage detail url is limited office network access)

lines: 42.9% (48465 out of 112866)
branches: 6.2% (75625 out of 1215153)

@ti-chi-bot ti-chi-bot merged commit c10ce0b into pingcap:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants