Skip to content

Do background compaction when the ratio of stable data covered by delete range is too large#3703

Merged
ti-chi-bot merged 6 commits intorelease-5.0from
add-bg-gc-5.0
Jun 3, 2022
Merged

Do background compaction when the ratio of stable data covered by delete range is too large#3703
ti-chi-bot merged 6 commits intorelease-5.0from
add-bg-gc-5.0

Conversation

@lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Dec 22, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3659

Problem Summary: If some segments was generated by logical split, the new segments will keep the delete range of the old segment. And by the old gc logic, the rows in stable covered by delete range is larger than the valid rows in the stable which will skip gc on these segments.
The original purpose of this check is to prevent small segments to merge delta. But after some detail investigation, this check is really unnecessary.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the problem that obsolete data cannot be reclaimed after set tiflash replica to 0

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 22, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 22, 2021
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 22, 2021

This is a cherry pick of #2416 and #3657

@lidezhu lidezhu added the CHERRY-PICK cherry pick label Dec 22, 2021
@lidezhu lidezhu modified the milestones: v5.0.6, v5.0.7 Dec 22, 2021
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 22, 2021

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 22, 2021

/run-all-tests

@lidezhu lidezhu self-assigned this Jan 28, 2022
@flowbehappy flowbehappy self-requested a review March 9, 2022 15:58
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2022
@lidezhu lidezhu mentioned this pull request Mar 14, 2022
Closed
12 tasks
@lidezhu lidezhu mentioned this pull request Mar 30, 2022
Closed
11 tasks
@CLAassistant
Copy link

CLAassistant commented Apr 2, 2022 •
edited by sre-bot
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Apr 27, 2022

/rebuild

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 2, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Jun 3, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2022

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 3, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bd6a60e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2022
@ti-chi-bot ti-chi-bot merged commit 2f8f481 into release-5.0 Jun 3, 2022
@lidezhu lidezhu deleted the add-bg-gc-5.0 branch June 3, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@lidezhu lidezhu

Labels

CHERRY-PICK cherry pick cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

v5.0.7

Development

Successfully merging this pull request may close these issues.

6 participants

@lidezhu @ti-chi-bot @CLAassistant @flowbehappy @JaySon-Huang @VelocityLight