Skip to content

Fix ci build break introduced by #3638#3672

Merged
ti-chi-bot merged 1 commit intopingcap:masterfrom
fuzhe1989:fuzhe/fix_ci
Dec 17, 2021
Merged

Fix ci build break introduced by #3638#3672
ti-chi-bot merged 1 commit intopingcap:masterfrom
fuzhe1989:fuzhe/fix_ci

Conversation

@fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Dec 17, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 17, 2021
@fuzhe1989
Copy link
Contributor Author

fuzhe1989 commented Dec 17, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2021

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7bb4f68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 17, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 17, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/434/cobertura/
(Coverage detail url is limited office network access)

lines: 42.5% (47532 out of 111811)
branches: 6.0% (73025 out of 1208747)

@ti-chi-bot ti-chi-bot merged commit c723d35 into pingcap:master Dec 17, 2021
@fuzhe1989 fuzhe1989 deleted the fuzhe/fix_ci branch December 17, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SeaRise SeaRise SeaRise approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fuzhe1989 @ti-chi-bot @sre-bot @SeaRise