Skip to content

PageStorage: Refactor snapshot base class#3646

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
JaySon-Huang:refactor_ps_snap
Dec 15, 2021
Merged

PageStorage: Refactor snapshot base class#3646
ti-chi-bot merged 7 commits intopingcap:masterfrom
JaySon-Huang:refactor_ps_snap

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 14, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: related to #3594

Problem Summary:

What is changed and how it works?

  • Add a base class DB::PageStorageSnapshot for snapshot in PageStorage V2 && V3 (just ignore V1 since we plan to remove it when 6.0 released)
  • Replace LOG_XXX with LOG_FMT_XXX in PageStorage V2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

JaySon-Huang and others added 3 commits December 14, 2021 13:45
@JaySon-Huang
Add a snapshot base class
e4c2e79 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Apply for V3
6aa69f2 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Fix page_ctl
caebab7 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 14, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 14, 2021
@JaySon-Huang
Use LOG_FMT_XXX instead of LOG_XXX
a23499d 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 14, 2021
Closed
76 tasks
@JaySon-Huang
Small fix
8080c70 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 14, 2021
Merged
12 tasks
@JaySon-Huang
Small fix
5f4b223 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 14, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 14, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/366/cobertura/
(Coverage detail url is limited office network access)

lines: 42.2% (46786 out of 110871)
branches: 6.0% (72080 out of 1205385)

jiaqizho
jiaqizho approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 15, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 5f4b223

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 15, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021

@JaySon-Huang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 15, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/375/cobertura/
(Coverage detail url is limited office network access)

lines: 42.4% (47055 out of 111054)
branches: 6.0% (72580 out of 1206184)

@ti-chi-bot ti-chi-bot merged commit 80da5f7 into pingcap:master Dec 15, 2021
@JaySon-Huang JaySon-Huang deleted the refactor_ps_snap branch December 15, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jiaqizho jiaqizho jiaqizho approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JaySon-Huang @ti-chi-bot @sre-bot @jiaqizho