Skip to content

Fix Space map build error#3628

Merged
JaySon-Huang merged 2 commits intopingcap:masterfrom
jiaqizho:fix-spacemap-build
Dec 10, 2021
Merged

Fix Space map build error#3628
JaySon-Huang merged 2 commits intopingcap:masterfrom
jiaqizho:fix-spacemap-build

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Dec 10, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

error: ‘new_entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 10, 2021
@jiaqizho jiaqizho requested a review from mengxin9014 December 10, 2021 08:01
JaySon-Huang
JaySon-Huang approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Fix the CI error first.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 10, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Dec 10, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2021

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b7f266e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 10, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 10, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/326/cobertura/
(Coverage detail url is limited office network access)

lines: 41.9% (46376 out of 110661)
branches: 5.8% (69691 out of 1201916)

@JaySon-Huang JaySon-Huang merged commit 7a0a731 into pingcap:master Dec 10, 2021
@JaySon-Huang JaySon-Huang deleted the fix-spacemap-build branch December 10, 2021 09:21
@JaySon-Huang JaySon-Huang mentioned this pull request Jan 7, 2022
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

+1 more reviewer

@mengxin9014 mengxin9014 mengxin9014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jiaqizho @ti-chi-bot @sre-bot @JaySon-Huang @mengxin9014