Skip to content

Remove ClickHouse StorageDistributed#3618

Merged
ti-chi-bot merged 15 commits intopingcap:masterfrom
JaySon-Huang:remove_distribute
Dec 9, 2021
Merged

Remove ClickHouse StorageDistributed#3618
ti-chi-bot merged 15 commits intopingcap:masterfrom
JaySon-Huang:remove_distribute

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 8, 2021

What problem does this PR solve?

Issue Number: close #3484

Problem Summary: Remove ClickHouse StorageDistributed and its related functions

What is changed and how it works?

  • Remove StorageDistributed
  • Remove "remote table function" inherited from ClickHouse
  • Remove "cluster" inherited from ClickHouse
  • Remove useless settings in Settings.h

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@JaySon-Huang
Remove StorageDistributed
4454d67 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove InJoinSubqueriesPreprocessor
2810f1e 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove TableFunctionShardByHash
49631d6 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove TableFunctionRemote
ee1527a 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove getStructureOfRemoteTable
41c8cd5 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove cluster query helper
0753d4d 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove Clickhouse cluster-related logic
ededcb1 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove ASTQueryWithOnCluster
ffd4853 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Restore settings.h
89d19a5 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove useless settings
39a3188 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Format files
3e888b8 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 8, 2021
@JaySon-Huang JaySon-Huang self-assigned this Dec 8, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 8, 2021
@JaySon-Huang JaySon-Huang added type/code-quality-improvement PR that can improve the code quality and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 8, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 8, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/295/cobertura/
(Coverage detail url is limited office network access)

lines: 41.3% (45073 out of 109144)
branches: 5.7% (68106 out of 1197326)

@JaySon-Huang
Remove useless test files
bcec6c0 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 9, 2021
@JaySon-Huang
Fix
d8e841b 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
lidezhu
lidezhu approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 9, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 9, 2021

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 9, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d8e841b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 9, 2021

/rebuild

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 9, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/314/cobertura/
(Coverage detail url is limited office network access)

lines: 41.5% (45631 out of 109926)
branches: 5.7% (68689 out of 1199456)

@ti-chi-bot ti-chi-bot merged commit 8bfd258 into pingcap:master Dec 9, 2021
@JaySon-Huang JaySon-Huang deleted the remove_distribute branch December 9, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidezhu lidezhu lidezhu approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees

@JaySon-Huang JaySon-Huang

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/code-quality-improvement PR that can improve the code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove StorageDistributed

4 participants

@JaySon-Huang @ti-chi-bot @sre-bot @lidezhu