Skip to content

Remove MergeTree family#3564

Merged
ti-chi-bot merged 15 commits intopingcap:masterfrom
JaySon-Huang:remove_merge_tree
Dec 1, 2021
Merged

Remove MergeTree family#3564
ti-chi-bot merged 15 commits intopingcap:masterfrom
JaySon-Huang:remove_merge_tree

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Nov 29, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3481, should merge #3563 first

Problem Summary: MergeTree family is deprecated in TiFlash. These codes are useless.

What is changed and how it works?

  • Remove *MergeTree family
  • Remove PersistedCache
  • Remove PartLog https://clickhouse.com/docs/en/operations/system-tables/part_log/
  • Remove MergeTreeSetIndex
  • Remove PartPathSelector
  • Remove system.{merge,parts,parts_columns}
  • Remove TxnMergeTree data stream:
    • Remove TMTSortCursor
    • Remove MvccTMTSortedBlockInputStream/ReplacingTMTSortedBlockInputStream/TMTSingleSortedBlockInputStream/TMTSortedBlockInputStream/TMTUnionBlockInputStream

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@JaySon-Huang JaySon-Huang added the type/code-quality-improvement PR that can improve the code quality label Nov 29, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2021
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 29, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 29, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/214/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44314 out of 110047)
branches: 5.6% (67040 out of 1197792)

@JaySon-Huang JaySon-Huang mentioned this pull request Nov 30, 2021
Closed
6 tasks
@JaySon-Huang
Remove mergetree dir
1221118 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove PersistedCache
b07f9aa 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove PartPathSelector
8472064 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove PartLog
8605d81 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove MergeTreeSetIndex
4a9c17a 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove others
97188b0 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Remove useless data streams
cffb4ca 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Format files
3a433db 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Cleanup
0574677 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Cleanup for PartPathSelector
dddd3fe 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Cleanup useless ProfileEvents
893dd63 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 30, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 30, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/216/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44393 out of 110046)
branches: 5.6% (67113 out of 1197788)

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 30, 2021

/run-integration-test

@JaySon-Huang
Fix
eb2e9be 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 30, 2021

/run-integration-test

@JaySon-Huang
fix
27060de 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 30, 2021

/run-integration-test

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Nov 30, 2021

/run-unit-test

@JaySon-Huang JaySon-Huang changed the title [WIP] Remove MergeTree family Remove MergeTree family Nov 30, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 30, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/217/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44398 out of 110046)
branches: 5.6% (67108 out of 1197788)

JaySon-Huang
JaySon-Huang commented Nov 30, 2021
View reviewed changes
@SchrodingerZhu
Copy link
Contributor

SchrodingerZhu commented Nov 30, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 30, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/218/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44312 out of 110046)
branches: 5.6% (67033 out of 1197788)

@JaySon-Huang
Fix error under MacOS
f65823a 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 1, 2021

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Dec 1, 2021

/cc @flowbehappy @solotzg @fuzhe1989

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 1, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/221/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44316 out of 110046)
branches: 5.6% (67034 out of 1197788)

@SchrodingerZhu
Copy link
Contributor

SchrodingerZhu commented Dec 1, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2021

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 1, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: f65823a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 1, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 1, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/222/cobertura/
(Coverage detail url is limited office network access)

lines: 40.3% (44310 out of 110046)
branches: 5.6% (67029 out of 1197788)

@ti-chi-bot ti-chi-bot merged commit 82af1aa into pingcap:master Dec 1, 2021
@JaySon-Huang JaySon-Huang deleted the remove_merge_tree branch December 1, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@solotzg solotzg solotzg approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/code-quality-improvement PR that can improve the code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove MergeTree family

6 participants

@JaySon-Huang @ti-chi-bot @sre-bot @SchrodingerZhu @flowbehappy @solotzg