Skip to content

remove interserver_http_port code#3547

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
hehechen:remove_interserver_http_port
Nov 26, 2021
Merged

remove interserver_http_port code#3547
ti-chi-bot merged 7 commits intopingcap:masterfrom
hehechen:remove_interserver_http_port

Conversation

@hehechen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #3491

Problem Summary:
The configuration interserver_http_port is unused in TiFlash, we can remove it from source code.

What is changed and how it works?

What's Changed:
Remove code related tointerserver_http_port.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2021
@hehechen hehechen closed this Nov 25, 2021
@hehechen hehechen reopened this Nov 25, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2021
@hehechen hehechen force-pushed the remove_interserver_http_port branch from c5c2c12 to 1d78fac Compare November 25, 2021 07:50
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 25, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/154/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43331 out of 121987)
branches: 5.4% (65900 out of 1219620)

@hehechen hehechen self-assigned this Nov 26, 2021
@hehechen hehechen force-pushed the remove_interserver_http_port branch from 6c246aa to 9f2b20d Compare November 26, 2021 02:45
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2021
@hehechen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 9f2b20d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 26, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 26, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/172/cobertura/
(Coverage detail url is limited office network access)

lines: 35.6% (43450 out of 122046)
branches: 5.4% (66023 out of 1219906)

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 26, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/178/cobertura/
(Coverage detail url is limited office network access)

lines: 35.6% (43452 out of 122046)
branches: 5.4% (66028 out of 1219906)

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 26, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/183/cobertura/
(Coverage detail url is limited office network access)

lines: 36.7% (44879 out of 122337)
branches: 5.5% (67558 out of 1222067)

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 26, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/186/cobertura/
(Coverage detail url is limited office network access)

lines: 36.7% (44872 out of 122345)
branches: 5.5% (67551 out of 1222069)

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 26, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/193/cobertura/
(Coverage detail url is limited office network access)

lines: 36.7% (45006 out of 122503)
branches: 5.5% (67683 out of 1222575)

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 26, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/196/cobertura/
(Coverage detail url is limited office network access)

lines: 36.8% (45094 out of 122503)
branches: 5.5% (67777 out of 1222575)

@ti-chi-bot ti-chi-bot merged commit 239295a into pingcap:master Nov 26, 2021
@JaySon-Huang JaySon-Huang deleted the remove_interserver_http_port branch November 26, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused configuration "interserver_http_port"

4 participants