remove interserver_http_port code#3547
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
c5c2c12 to
1d78fac
Compare
|
/run-all-tests |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/154/cobertura/ lines: 35.5% (43331 out of 121987) |
6c246aa to
9f2b20d
Compare
|
/merge |
|
@hehechen: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 9f2b20d |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/172/cobertura/ lines: 35.6% (43450 out of 122046) |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/178/cobertura/ lines: 35.6% (43452 out of 122046) |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/183/cobertura/ lines: 36.7% (44879 out of 122337) |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/186/cobertura/ lines: 36.7% (44872 out of 122345) |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/193/cobertura/ lines: 36.7% (45006 out of 122503) |
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/196/cobertura/ lines: 36.8% (45094 out of 122503) |
What problem does this PR solve?
Issue Number: close #3491
Problem Summary:
The configuration
interserver_http_portis unused in TiFlash, we can remove it from source code.What is changed and how it works?
What's Changed:
Remove code related to
interserver_http_port.Check List
Tests
Release note