Skip to content

Clean dbms/tests#3540

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
solotzg:rm-useless-files
Nov 25, 2021
Merged

Clean dbms/tests#3540
ti-chi-bot merged 3 commits intopingcap:masterfrom
solotzg:rm-useless-files

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented Nov 24, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3485

What is changed and how it works?

What's Changed:

  • rm dbms/tests

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

None

@solotzg solotzg requested a review from JaySon-Huang November 24, 2021 02:53
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2021
@solotzg
Copy link
Contributor Author

solotzg commented Nov 24, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 24, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/135/cobertura/
(Coverage detail url is limited office network access)

lines: 36.4% (43296 out of 118871)
branches: 5.4% (65845 out of 1214304)

@solotzg
Copy link
Contributor Author

solotzg commented Nov 24, 2021

/run-integration-tests

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Nov 24, 2021

Can you file a separate PR only focusing on removing files under dbms/tests? This PR mixes too many other changes.

@solotzg
fix
38dfe80 
Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor Author

solotzg commented Nov 24, 2021

Can you file a separate PR only focusing on removing files under dbms/tests? This PR mixes too many other changes.

Fixed

@solotzg solotzg changed the title Clean part of useless files Clean dbms/tests Nov 24, 2021
JaySon-Huang
JaySon-Huang approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2021
@solotzg solotzg added the type/code-quality-improvement PR that can improve the code quality label Nov 24, 2021
@solotzg
Copy link
Contributor Author

solotzg commented Nov 24, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 24, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 38dfe80

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 24, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 24, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/144/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43335 out of 122148)
branches: 5.4% (65917 out of 1219969)

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 25, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/150/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43336 out of 122148)
branches: 5.4% (65917 out of 1219969)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2021

@solotzg: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 25, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/159/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43334 out of 122148)
branches: 5.4% (65917 out of 1219969)

@ti-chi-bot ti-chi-bot merged commit e7159d8 into pingcap:master Nov 25, 2021
@solotzg solotzg deleted the rm-useless-files branch November 25, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/code-quality-improvement PR that can improve the code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove ClickHouse integration test cases under dbms/tests

4 participants

@solotzg @ti-chi-bot @sre-bot @JaySon-Huang